Skip to content

Commit

Permalink
List (mobile): Fix to apply a GUI feedback part.2
Browse files Browse the repository at this point in the history
[Issue] #980
[Problem] Need to adjust some styles according to GUI feedback
[Solution]
- Adjust the basic list 1, 2, and 3 line
- Add some icons and remove an unnecessary margin

Signed-off-by: Hunseop Jeong <hs85.jeong@samsung.com>
  • Loading branch information
HunseopJeong authored and singa2000 committed Apr 23, 2020
1 parent b629947 commit 74df016
Show file tree
Hide file tree
Showing 7 changed files with 113 additions and 11 deletions.
23 changes: 18 additions & 5 deletions examples/mobile/UIComponents/components/list/icon-text-list.html
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
<ul class="ui-listview ui-content-area">
<li class="ui-li-has-icon ui-li-divider">
<div class="ui-li-icon">
<img src="images/thumbnail.jpg"/>
<img src="images/tw_list_icon_connections.svg"/>
</div>
<div class="ui-li-text">
<span class="ui-li-text-title">
Expand All @@ -39,7 +39,7 @@
</li>
<li class="ui-li-has-icon">
<div class="ui-li-icon">
<img src="images/thumbnail.jpg"/>
<img src="images/tw_list_icon_sound.svg"/>
</div>
<div class="ui-li-text">
<span class="ui-li-text-title">
Expand All @@ -54,7 +54,7 @@
<ul class="ui-listview ui-content-area">
<li class="ui-li-has-icon ui-li-divider">
<div class="ui-li-icon">
<img src="images/thumbnail.jpg"/>
<img src="images/tw_list_icon_notifications.svg"/>
</div>
<div class="ui-li-text">
<span class="ui-li-text-title">
Expand All @@ -65,9 +65,9 @@
</span>
</div>
</li>
<li class="ui-li-has-icon">
<li class="ui-li-has-icon ui-li-divider">
<div class="ui-li-icon">
<img src="images/thumbnail.jpg"/>
<img src="images/tw_list_icon_display.svg"/>
</div>
<div class="ui-li-text">
<span class="ui-li-text-title">
Expand All @@ -78,6 +78,19 @@
</span>
</div>
</li>
<li class="ui-li-has-icon">
<div class="ui-li-icon">
<img src="images/tw_list_icon_wallpaper.svg"/>
</div>
<div class="ui-li-text">
<span class="ui-li-text-title">
Main text 05
</span>
<span class="ui-li-text-sub">
Brightness, Blue light filter, font
</span>
</div>
</li>
</ul>
</div>
</div>
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
21 changes: 15 additions & 6 deletions src/css/profile/mobile/common/listview.less
Original file line number Diff line number Diff line change
Expand Up @@ -140,25 +140,34 @@ tau-expandable {
}
}

&.ui-li-has-icon {
margin-left: 12 * @px_base;
}

// Text
.ui-li-text {
display: inline-flex;
flex-direction: column;
padding: 14 * @px_base 0;
padding: 15 * @px_base 0;
margin-right: 24 * @px_base;

.ui-li-text-title {
font-size: 18 * @sp_base;
color: var(--text-color);
line-height: 21 * @px_base;

&:only-child {
padding-bottom: @px_base;
}

// line height between title and sub
&+.ui-li-text-sub::before {
content: "";
display: block;
height: 4 * @px_base;
}
}

.ui-li-text-sub {
font-size: @font_size_list_secondary_text;
font-size: 13 * @sp_base;
color: var(--text-secondary-color);
line-height: 15 * @px_base;

img {
width: 15 * @px_base;
Expand Down

0 comments on commit 74df016

Please sign in to comment.