Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML Assistant can't close after losing the focus #269

Closed
singa2000 opened this issue Aug 13, 2019 · 4 comments
Closed

HTML Assistant can't close after losing the focus #269

singa2000 opened this issue Aug 13, 2019 · 4 comments
Assignees
@korneliakobiela @singa2000
Labels
bug Something isn't working important in review Development done, review before merge
Milestone
M2

Comments

@singa2000
Copy link
Collaborator

Technical

WATT/ VSCode

Description

HTML Assistant can't close after losing the focus

Steps to reproduce

  1. Create a new project in Design Editor
  2. Drag&Drop the Text and Open the HTML Assistant
  3. Mouse focus elsewhere except on HTML Assistant and Template and click
  4. Again "HTML Assistant" button for close the HTML Assistant window

Expected behaviour

Close the HTML Assistant window

Actual behaviour

HTML Assistant can't close after click the mouse outside the HTML Assistant or Template
@singa2000 singa2000 added bug Something isn't working important labels Aug 13, 2019
@lmslachciak lmslachciak added this to the M2 milestone Aug 13, 2019
@korneliakobiela korneliakobiela self-assigned this Aug 19, 2019
@korneliakobiela korneliakobiela added the in progress Someone is now working on this issue label Aug 19, 2019
korneliakobiela pushed a commit to korneliakobiela/TAU-Design-Editor that referenced this issue Aug 23, 2019
Closing HTML Assistant on loose element focus
050a910 
Issue: Samsung#269
Problem: HTML Assistant cannot close when focus is lost
Solution: When focus lost HTML Assistant close by itself

Signed-off-by: Kornelia Kobiela <k.kobiela@samsung.com>
@korneliakobiela korneliakobiela mentioned this issue Aug 23, 2019
Merged
korneliakobiela pushed a commit to korneliakobiela/TAU-Design-Editor that referenced this issue Aug 23, 2019
Closing HTML Assistant on loose element focus
9d32b16 
Issue: Samsung#269
Problem: HTML Assistant cannot close when focus is lost
Solution: When focus lost HTML Assistant close by itself

Signed-off-by: Kornelia Kobiela <k.kobiela@samsung.com>
korneliakobiela pushed a commit that referenced this issue Aug 23, 2019
Closing HTML Assistant on loose element focus
bdda39f 
Issue: #269
Problem: HTML Assistant cannot close when focus is lost
Solution: When focus lost HTML Assistant close by itself

Signed-off-by: Kornelia Kobiela <k.kobiela@samsung.com>
@korneliakobiela
Copy link

Issue is done.

@korneliakobiela korneliakobiela added in review Development done, review before merge and removed in progress Someone is now working on this issue labels Aug 26, 2019
@singa2000
Copy link
Collaborator Author

singa2000 commented Aug 27, 2019 •
edited
Loading

Dear Korrnelia
Would you check HTML Assistant and JavaScript Assistant after apply the https://github.sec.samsung.net/HighPerformanceWeb/VSC-Design-Editor/pull/75 in the VSCode, please?
It looks Some feature is not working after merge the VSC-Design-Editor/pull/75.

In the WATT, it's good working.

@korneliakobiela
Copy link

Dear Hwang,
I can't reproduce this issue. Please check that your VSC Design Editor is up to date git pull and then check its submodule is up to date. Then it works for me.

@singa2000
Copy link
Collaborator Author

ok. The HTML Assistant is good working.
We can be close issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@korneliakobiela korneliakobiela

@singa2000 singa2000

Labels
bug Something isn't working important in review Development done, review before merge
Projects
None yet
Milestone
M2
Development

No branches or pull requests
3 participants
@lmslachciak @korneliakobiela @singa2000