Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPad pro (simulator) support #33

Open
flandy84 opened this issue Nov 28, 2015 · 2 comments
Open

IPad pro (simulator) support #33

flandy84 opened this issue Nov 28, 2015 · 2 comments

Comments

@flandy84
Copy link

new device, new problems :)

Please add iPadPro support for your menu. (Without blank areas between menu and content)

@flandy84
Copy link
Author

flandy84 commented Dec 3, 2015

ok - small update

it seems to be the the same/older issue here --> #14

currently available "relative"-positioning-API of this slide-menu library forces developers to write device-size-dependent-code with magic-numbers, like this:

    if max(UIScreen.mainScreen().bounds.size.height, UIScreen.mainScreen().bounds.size.width) <= 1024{ //"regular" iPads and iPhones
        configure(SSASideMenu.ContentViewEffect(alpha: 1.0, scale: 1, landscapeOffsetX: -200, portraitOffsetX: -75))
    }else{  //"pro" iPads
        configure(SSASideMenu.ContentViewEffect(alpha: 1.0, scale: 1, landscapeOffsetX: -370, portraitOffsetX: -200))
    } 

please provide an update to your API with "fix"-menu-width-property . #14 ("I am very sorry this hasn't been done yet. I will try to get some time to do this in the upcoming week. ")

:)

thank you a lot for this great and simple library

@SSA111
Copy link
Owner

SSA111 commented Dec 7, 2015

A PR is very much appreciated. I currently don't have time to look at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants