Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the delete method for JDBCConnector #82

Closed
qxzzxq opened this issue Jan 27, 2020 · 0 comments
Closed

Implement the delete method for JDBCConnector #82

qxzzxq opened this issue Jan 27, 2020 · 0 comments
Labels
feature New feature or request good first issue Good for newcomers

Comments

@qxzzxq
Copy link
Member

qxzzxq commented Jan 27, 2020

Is your feature request related to a problem? Please describe.
We'd like to be able to delete rows of a table in the database.

Describe the solution you'd like
As the connection information is given in the configuration, we can use java.sql.DriverManager to create the DB connection. Then we can generate and execute the SQL query with the connection.

If possible, check also if we can retrieve the connection directly from Spark. You may need to read a bit of the Spark source code 😃 (cf. org.apache.spark.sql.execution.datasources.jdbc.JdbcUtils)

The input argument "query" should contain only the condition of a complete SQL request. An exception should be thrown if the query is not well formated.

This issue is similar to #81

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants