Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sg-wrapper being ignored all over the project #1027

Closed
marinho opened this issue Nov 5, 2016 · 2 comments
Closed

sg-wrapper being ignored all over the project #1027

marinho opened this issue Nov 5, 2016 · 2 comments

Comments

@marinho
Copy link

marinho commented Nov 5, 2016

I am a beginner in sc5-styleguide.

I've just created my own project copying the files package.json and gulpfile.js from sc5-styleguide-tutorial.

The styleguide is generated alright, including sg-insert and basic KSS support, but when sg-wrapper is completely ignored. No errors. Just the built styleguide renders the markup without wrapping HTML.

Funny that I couldn't see any difference between my code and sc5-styleguide-tutorial, but sc5-styleguide-tutorial generates atoms.scss correctly with sg-wrapper.

Here is the gist of gulpfile.js and one of my scss files:

Update

I noticed that sc5-stylesheet version was quite outdated in sc5-stylesheet-tutorial. So I replaced my gulp.js by the example provided in the README.md file, as in the gist below. But the issue with sg-wrapper still happens.

@marinho
Copy link
Author

marinho commented Nov 5, 2016

Ooh, I found why: the KSS notation had a white space after the double slash comment just above sg-wrapper, as below:

// </header>
// <--- here
// sg-wrapper:

Curious that it seems KSS itself doesn't prohibit that, and the other spacings between other sections such as Title and Description, Stylesheet, etc. are fine and accepted.

To me, that seems a bug in sc5-styleguide.

@varya
Copy link
Contributor

varya commented Nov 10, 2016

Thank you. This was a bug. It's fixed here #1031 Please wait for the pull request to be merge and for the next release.

@varya varya closed this as completed Jan 16, 2017
cyberixae referenced this issue in cyberixae/sc5-styleguide Aug 24, 2018
…n-kss-parameters

Allow trailing spaces in between KSS parameters. Fix#1027
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants