Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Custom Middleware Extensibility: Allow multiple definitions of the same custom middleware #246

Merged
merged 4 commits into from
Oct 14, 2019

Conversation

RandomByte
Copy link
Member

@RandomByte RandomByte force-pushed the allow-same-name-custom-middleware-configurations branch from a3d516b to 2ec8daf Compare October 10, 2019 14:59
@coveralls
Copy link

coveralls commented Oct 10, 2019

Coverage Status

Coverage increased (+0.02%) to 93.509% when pulling b59b6c1 on allow-same-name-custom-middleware-configurations into 1188029 on master.

@vobu
Copy link

vobu commented Oct 11, 2019

was looking fwd to this for quite a while :)
gave it a shot immediately via
https://github.com/petermuessig/ui5-ecosystem-showcase/blob/c8cfc38e22c72ef293ff3cb175bf79e3cb9c97f1/packages/ui5-app/package.json#L39
and
https://github.com/petermuessig/ui5-ecosystem-showcase/blob/c8cfc38e22c72ef293ff3cb175bf79e3cb9c97f1/packages/ui5-app/ui5.yaml#L29
but
yarn dev then bails with
Error: middlewareRepository: Unknown Middleware ui5-middleware-simpleproxy--1

Am I doing sth wrong?

@RandomByte
Copy link
Member Author

Thanks for testing this right away @vobu!

That was my bad. Fix coming right up!

@petermuessig
Copy link
Contributor

@vobu thanks for requesting! we can adopt the ecosystem showcase then - @RandomByte thanks for featuring! :-)

@vobu
Copy link

vobu commented Oct 11, 2019

Thanks for testing this right away @vobu!

That was my bad. Fix coming right up!

confirmed: it's ALIVE 🧟‍♂️ !!! :)

as soon as this is alive, I'll PR the showcase @petermuessig

@RandomByte RandomByte requested a review from Thodd October 14, 2019 12:15
@RandomByte RandomByte merged commit 55a24ef into master Oct 14, 2019
@RandomByte RandomByte deleted the allow-same-name-custom-middleware-configurations branch October 14, 2019 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom Middleware Reusability
5 participants