Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Schema: Introduce specVersion 4.0 #731

Merged
merged 10 commits into from
Jun 21, 2024
Merged

[FEATURE] Schema: Introduce specVersion 4.0 #731

merged 10 commits into from
Jun 21, 2024

Conversation

d3xter666
Copy link
Contributor

JIRA: CPOUI5FOUNDATION-835

@d3xter666 d3xter666 marked this pull request as draft June 11, 2024 07:50
@coveralls
Copy link

Coverage Status

coverage: 95.719%. remained the same
when pulling ada81b6 on spec-version-4
into f33bd8e on main.

@d3xter666 d3xter666 marked this pull request as ready for review June 11, 2024 10:33
@d3xter666 d3xter666 requested a review from a team June 11, 2024 10:34
@coveralls
Copy link

Coverage Status

coverage: 95.719%. remained the same
when pulling 89f9485 on spec-version-4
into f33bd8e on main.

d3xter666 and others added 4 commits June 20, 2024 11:00
@d3xter666 @RandomByte
Update test/lib/validation/schema/__helper__/builder-bundleOptions.js
e810a44 
Co-authored-by: Merlin Beutlberger <m.beutlberger@sap.com>
@d3xter666 @RandomByte
Update test/lib/validation/schema/specVersion/kind/project/applicatio…
5e9c5be 
…n.js

Co-authored-by: Merlin Beutlberger <m.beutlberger@sap.com>
@d3xter666 @RandomByte
Update test/lib/validation/schema/specVersion/kind/project/library.js
ea473ea 
Co-authored-by: Merlin Beutlberger <m.beutlberger@sap.com>
@d3xter666
fix tests
919d675
@coveralls
Copy link

Coverage Status

coverage: 95.719%. remained the same
when pulling 919d675 on spec-version-4
into f33bd8e on main.

@d3xter666 d3xter666 merged commit c5a9fde into main Jun 21, 2024
17 checks passed
@d3xter666 d3xter666 deleted the spec-version-4 branch June 21, 2024 09:26
@d3xter666 d3xter666 mentioned this pull request Jul 17, 2024
Merged
d3xter666 added a commit that referenced this pull request Jul 18, 2024
@d3xter666
[INTERNAL] Determine correctly mode=require sections and restrict the…
6cc24f9 
… async flag (#751)

JIRA: CPOUI5FOUNDATION-835

This change addresses the commnents in
#731
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matz3 matz3 matz3 left review comments

@flovogt flovogt flovogt left review comments

@RandomByte RandomByte RandomByte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@d3xter666 @coveralls @matz3 @RandomByte @flovogt