[FEATURE] Sapui5MavenSnapshotResolver: Use npm-dist.zip artifact for 1.116.0 and later #622
Conversation
… 1.116.0 and later
…nder different name from default JAR This is to ensure compatibility with old UI5 Tooling versions that are used in parallel. An old version might download the default JAR for 1.117.0-SNAPSHOT and store it under "<library name>-prebuilt". While a new UI5 Tooling version would expect the content of the npm-dist.zip artifact under that name. Therefore, we use a new name for storing the new artifact.
|
LGTM |
| // Add "-prebuilt_dist" suffix to package name | ||
| // We can't use "-prebuilt" since old ui5-project versions might continue to download | ||
| // and store the default JAR under that name too | ||
| pkgName += "-prebuilt_dist"; |
There was a problem hiding this comment.
I wonder whether this is really the best solution. This is not the actual package name anymore.
Maybe the installer should rather have the knowledge on how to name the folders, because that's what is important here. The package name is actually not changing.
There was a problem hiding this comment.
could we not just use the same name and ask for using the latest ui5-project?
There was a problem hiding this comment.
I also expect this to cause trouble. We need to use a different folder name. But only that and maybe the lock name need to differ.
There was a problem hiding this comment.
Matthias and I found a potential solution to this. With the latest commit, we check whether the found "-prebuilt" package actually contains a package.json (which is only the case for the new npm-dist.zip artifact). In case no package.json is found, the installed package is overwritten with a newly installed npm-dist.zip package 👍
with installed content from previous ui5-project versions. The prebuilt package previously didn't contain a package.json. Now we only consider a package to be installed when it has a package.json This causes old jar based packages that already exist to be removed and replaced by the new npm-dist.zip contents.
RandomByte
force-pushed
the
snapshot-use-npm-dist
branch
from
7ccd170
to
cb75240
Compare
RandomByte
changed the title
Use the SAP-internal npm-dist.zip instead of the default JAR when consuming SNAPSHOT versions.
This artifact also contains selected test-resources and will eventually be published to the public npm registry.
Since the extracted content is stored under the same directory path as the default JAR is stored in previous versions,
we now only consider a package to be installed when it has a package.json. This causes old jar based packages that already exist to be removed and replaced by the new npm-dist.zip contents.
JIRA: CPOUI5FOUNDATION-672