Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BREAKING] Transform module to ESM #398

Merged
merged 42 commits into from
Oct 24, 2022
Merged

[BREAKING] Transform module to ESM #398

merged 42 commits into from
Oct 24, 2022

Conversation

matz3
Copy link
Member

@matz3 matz3 commented Sep 13, 2022

JIRA: CPOUI5FOUNDATION-525

@matz3 matz3 changed the base branch from master to next September 13, 2022 13:49
matz3
matz3 commented Sep 14, 2022
View reviewed changes
package.json Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Sep 23, 2022 •
edited
Loading

Coverage Status

Coverage decreased (-0.04%) to 87.268% when pulling 9c721be on esm into a18fc04 on next.

@RandomByte
Copy link
Member

[BREAKING CHAMGE] AbstractReader: migrate subreader calls to async

This commit is actually not breaking, since the changed API has only been added in v3 and is not public yet.

@flovogt flovogt changed the title [WIP][BREAKING] Transform module to ESM [FEATURE] Transform module to ESM Sep 30, 2022
@flovogt

This comment was marked as resolved.

Sign in to view
@matz3 matz3 changed the title [FEATURE] Transform module to ESM [BREAKING] Transform module to ESM Oct 5, 2022
matz3 and others added 2 commits October 7, 2022 10:16
@matz3
Fix Link/Filter JSDoc, make Transformer private
6a1a486 
Transformer should be removed anyways in a follow-up PR
@flovogt
add empty line before comment
3d43fd3
RandomByte
RandomByte previously approved these changes Oct 20, 2022
View reviewed changes
flovogt
flovogt requested changes Oct 21, 2022
View reviewed changes
lib/AbstractReader.js Outdated Show resolved Hide resolved
lib/readers/Transformer.js Show resolved Hide resolved
lib/resourceFactory.js Outdated Show resolved Hide resolved
test/lib/fsInterface.js Outdated Show resolved Hide resolved
flovogt
flovogt previously approved these changes Oct 24, 2022
View reviewed changes
@flovogt flovogt merged commit 2b61580 into next Oct 24, 2022
@flovogt flovogt deleted the esm branch October 24, 2022 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RandomByte RandomByte RandomByte approved these changes

@flovogt flovogt flovogt left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matz3 @coveralls @RandomByte @flovogt