[FIX] ui5 init: Improve error message #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KlattG
suggested changes
Oct 26, 2023
lib/init/init.js
Outdated
| @@ -49,6 +49,9 @@ function getProjectType(hasWebapp, hasSrc, hasTest) { | |||
| let message = `Could not detect project type: ${errorReason}`; | |||
| message += "Applications should only have a 'webapp' folder.\n"; | |||
| message += "Libraries should only have a 'src' and (optional) 'test' folder."; | |||
There was a problem hiding this comment.
Suggested change
| message += "Libraries should only have a 'src' and (optional) 'test' folder."; | |
| message += "Libraries should only have an 'src' and (optional) 'test' folder."; |
lib/init/init.js
Outdated
| @@ -49,6 +49,9 @@ function getProjectType(hasWebapp, hasSrc, hasTest) { | |||
| let message = `Could not detect project type: ${errorReason}`; | |||
| message += "Applications should only have a 'webapp' folder.\n"; | |||
| message += "Libraries should only have a 'src' and (optional) 'test' folder."; | |||
| message += "\n\n"; | |||
| message += "In case you are about to start a new project, please refer to:\n"; | |||
There was a problem hiding this comment.
Suggested change
| message += "In case you are about to start a new project, please refer to:\n"; | |
| message += "If you are about to start a new project, please refer to:\n"; |
test/lib/init/init.js
Outdated
| @@ -40,49 +40,50 @@ test("Init for library", async (t) => { | |||
| }); | |||
| }); | |||
|
|
|||
| const GENERAL_ERROR_MESSAGE = `Applications should only have a 'webapp' folder. | |||
| Libraries should only have a 'src' and (optional) 'test' folder. | |||
There was a problem hiding this comment.
Suggested change
| Libraries should only have a 'src' and (optional) 'test' folder. | |
| Libraries should only have an 'src' and (optional) 'test' folder. |
test/lib/init/init.js
Outdated
| const GENERAL_ERROR_MESSAGE = `Applications should only have a 'webapp' folder. | ||
| Libraries should only have a 'src' and (optional) 'test' folder. | ||
|
|
||
| In case you are about to start a new project, please refer to: |
There was a problem hiding this comment.
Suggested change
| In case you are about to start a new project, please refer to: | |
| If you are about to start a new project, please refer to: |
flovogt
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: SAP/ui5-tooling#306