Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] builder: Improve support for ES6+ syntax #774

Merged
merged 11 commits into from
Sep 19, 2022

Conversation

matz3
Copy link
Member

@matz3 matz3 commented Jul 29, 2022

JIRA: CPOUI5FOUNDATION-374

@matz3 matz3 closed this Jul 29, 2022
@matz3 matz3 deleted the next-JSModuleAnalyzer-enhance-es6-syntax-tests branch July 29, 2022 12:50
@matz3 matz3 restored the next-JSModuleAnalyzer-enhance-es6-syntax-tests branch July 29, 2022 12:51
@matz3 matz3 reopened this Jul 29, 2022
@matz3 matz3 changed the base branch from master to next July 29, 2022 12:51
@matz3 matz3 changed the title next JSModuleAnalyzer enhance es6 syntax tests INTERNAL] JSModuleAnalyzer: Enhance ES6+ Syntax tests Jul 29, 2022
@matz3 matz3 changed the title INTERNAL] JSModuleAnalyzer: Enhance ES6+ Syntax tests [INTERNAL] JSModuleAnalyzer: Enhance ES6+ Syntax tests Jul 29, 2022
@coveralls
Copy link

coveralls commented Aug 2, 2022

Coverage Status

Coverage increased (+0.5%) to 94.51% when pulling d5ce05a on next-JSModuleAnalyzer-enhance-es6-syntax-tests into a6146a5 on next.

@flovogt flovogt force-pushed the next-JSModuleAnalyzer-enhance-es6-syntax-tests branch 3 times, most recently from 112207c to cb7e451 Compare August 4, 2022 06:54
@flovogt flovogt changed the title [INTERNAL] JSModuleAnalyzer: Enhance ES6+ Syntax tests [INTERNAL] Enhance ES6+ Syntax Aug 4, 2022
@flovogt flovogt force-pushed the next-JSModuleAnalyzer-enhance-es6-syntax-tests branch from 177df97 to 6f2793b Compare August 5, 2022 10:13
@flovogt flovogt changed the title [INTERNAL] Enhance ES6+ Syntax [WIP] [INTERNAL] Enhance ES6+ Syntax Aug 5, 2022
@matz3 matz3 force-pushed the next-JSModuleAnalyzer-enhance-es6-syntax-tests branch from efa5eab to 51cf739 Compare August 17, 2022 12:39
@codeworrior codeworrior changed the title [WIP] [INTERNAL] Enhance ES6+ Syntax [WIP] [INTERNAL] Enhance Support of ES6+ Syntax Aug 19, 2022
@flovogt flovogt force-pushed the next-JSModuleAnalyzer-enhance-es6-syntax-tests branch from 098331c to 49b0f73 Compare August 22, 2022 12:51
@matz3 matz3 changed the title [WIP] [INTERNAL] Enhance Support of ES6+ Syntax [INTERNAL] Improve support for ES6+ Syntax Aug 22, 2022
@flovogt flovogt force-pushed the next-JSModuleAnalyzer-enhance-es6-syntax-tests branch from 49b0f73 to 7308a04 Compare August 22, 2022 13:03
@flovogt flovogt force-pushed the next-JSModuleAnalyzer-enhance-es6-syntax-tests branch from 7308a04 to f3df91a Compare August 22, 2022 14:01
@flovogt flovogt changed the title [INTERNAL] Improve support for ES6+ Syntax [FEATURE] Improve support for ES6+ Syntax Aug 24, 2022
@flovogt flovogt force-pushed the next-JSModuleAnalyzer-enhance-es6-syntax-tests branch from 2a3884a to e4783b1 Compare August 25, 2022 11:14
lib/lbt/analyzer/FioriElementsAnalyzer.js Outdated Show resolved Hide resolved
test/lib/lbt/calls/SapUiDefine.js Outdated Show resolved Hide resolved
test/lib/lbt/calls/SapUiDefine.js Outdated Show resolved Hide resolved
}
});
}
if (defineCall.factory.async) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This message is IMO misleading. The ui5loader can handle async callbacks. The returned promise is just used as export value and delivered to anyone importing the module.

Here, the smart templates (FE v2) cannot handle such a promise. That's the reason why we should log a message.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Frank. Correct. So what should we log in case of the XMLComposite here the artefact can be placed in the view declaratively. The sap.ui.core.mvc.XMLView does not support returning a promise, correct? But do we know who consumes the XMLComposite. A typed view might import the asynchronously defined XMLComposite and can handle the asynchronism.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's handle this in a follow-up PR, so that we can merge the current changes.

@matz3 matz3 changed the title [FEATURE] Improve support for ES6+ Syntax [FEATURE] builder: Improve support for ES6+ Syntax Sep 8, 2022
@matz3 matz3 changed the title [FEATURE] builder: Improve support for ES6+ Syntax [FEATURE] builder: Improve support for ES6+ syntax Sep 8, 2022
To be added in a follow-up PR
Copy link
Member Author

@matz3 matz3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

Copy link
Member

@RandomByte RandomByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a rudimentary look, and LGTM

@matz3 matz3 merged commit 90385fe into next Sep 19, 2022
@matz3 matz3 deleted the next-JSModuleAnalyzer-enhance-es6-syntax-tests branch September 19, 2022 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants