Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Bundler: Ensure reproducibility for bundles with multiple parts #689

Merged
merged 3 commits into from
Jan 25, 2022

Conversation

matz3
Copy link
Member

@matz3 matz3 commented Jan 21, 2022

Sort modules in preload sections alphabetically.
This caused different bundle contents based on the order of modules that
the resolver provides, which is not deterministic.

Remove terser from size estimation as modules are now already optimized
if the 'optimize' bundle option is enabled.
This caused incorrect estimations about the bundle size which resulted
into size differences of the individual parts.

Sort modules in preload sections alphabetically.
This caused different bundle contents based on the order of modules that
the resolver provides, which is not deterministic.

Remove terser from size estimation as modules are now already optimized
if the 'optimize' bundle option is enabled.
This caused incorrect estimations about the bundle size which resulted
into size differences of the individual parts.
@matz3 matz3 marked this pull request as draft January 21, 2022 12:36
@matz3
Copy link
Member Author

matz3 commented Jan 21, 2022

Tests need to be updated / enhanced

@matz3 matz3 added the bug Something isn't working label Jan 21, 2022
@matz3 matz3 force-pushed the next-fix-AutoSplitter-reproducibility branch from a3a9244 to 10e6ce6 Compare January 21, 2022 13:21
@coveralls
Copy link

coveralls commented Jan 21, 2022

Coverage Status

Coverage decreased (-0.004%) to 94.786% when pulling dea9db6 on next-fix-AutoSplitter-reproducibility into 26084d1 on next.

@matz3 matz3 marked this pull request as ready for review January 21, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants