[FEATURE] manifestBundler: Add support for sap.app/i18n/enhanceWith #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As discussed in today's planning:
No. These i18n resources are not relevant for the manifest bundle. In addition: Check for |
IMO throwing an error would be incompatible. The protocol can already be used so I'd say we only log an error (as done with my recent commit) |
|
Then let's log a warning 👍 |
|
Windows tests are failing. I think we should really use |
RandomByte
requested changes
Dec 18, 2020
RandomByte
approved these changes
Dec 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bundleName(+ tests)sap.ui5/models/i18n/settings/enhanceWithalso be checked? -> No