Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CVE-2022-42889 affecting Apache Commons Text #348

Merged
merged 1 commit into from
Nov 21, 2022

Conversation

henrikplate
Copy link
Contributor

No description provided.

@copernico
Copy link
Contributor

copernico commented Nov 21, 2022

I run this command line (note: I did not even specify a version interval):

python client/cli/main.py CVE-2022-42889 --repository https://github.com/apache/commons-text --use-backend=optional

The tool found 654 candidates and the one that @henrikplate reported is no.5 (but the ones above it are quite clearly not security fixes).

When specifying a version interval, the commit found by Henrik is no.1 (but other irrelevant commits are assigned the same relevance).

My conclusion: using Prospector would have taken 29 seconds to produce the report + maybe another 30 s to pick the commit and export it in statement format (using the button in the report itself).

Question for @sacca97 : any idea why the PR apache/commons-text#341 (mentioned in the commit message) was not used? It has the CVE id in it....

Question for @henrikplate : what criteria did you use to pick that commit? And how long did it take for you to find it and decide it was the right one?

image

image

@copernico copernico merged commit 46b6932 into SAP:vulnerability-data Nov 21, 2022
@henrikplate
Copy link
Contributor Author

@copernico - I needed < 5 mins, because I knew that the vuln. was about string lookups, so it was easy to spot the corresponding commit message in the commits preceding the release.

@sacca97
Copy link
Collaborator

sacca97 commented Nov 21, 2022

I know I'm on a day off but my flight is late soo...
This is the report of the latest version which is not yet synched with Github. We're not detecting the CVE in the linked issue because that part of the issue is not in the Github API response.
But If we go back to scraping the html using BeautifulSoup we will get it.

immagine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants