Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 🐛 [JIRA:0] ThemeManager merge color definitions should not be called frequently #718

Merged
merged 10 commits into from
Jun 25, 2024
Merged

fix: 🐛 [JIRA:0] ThemeManager merge color definitions should not be called frequently #718

merged 10 commits into from
Jun 25, 2024

Conversation

restaurantt
Copy link
Contributor

No description provided.

@restaurantt restaurantt requested a review from a team as a code owner June 20, 2024 06:30
@restaurantt restaurantt requested review from billzhou0223 and removed request for a team June 20, 2024 06:30
billzhou0223
billzhou0223 requested changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@billzhou0223 billzhou0223 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the point of this PR?

dyongxu
dyongxu approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@dyongxu dyongxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note , after this is merged, need to update commit id on SAPFiori side (main branch).

Also, this PR needs to be cherrypicked to FioriIntegration24.4 branch. Then update commit id for SAPFiori rel-24.4 branch.

@restaurantt
fix: 🐛 [JIRA:0] ThemeManager merge color definitions func to static v…
cd32a76 
…ariable
@restaurantt
Merge branch 'main-mergedDeprecatedDefinitions' of https://github.com…
638f255 
…/restaurantt/cloud-sdk-ios-fiori into main-mergedDeprecatedDefinitions

# Conflicts:
#	Sources/FioriThemeManager/ThemeManager.swift
@restaurantt
Merge branch 'main-mergedDeprecatedDefinitions' of https://github.com…
f0bbb91 
…/restaurantt/cloud-sdk-ios-fiori into main-mergedDeprecatedDefinitions

# Conflicts:
#	Sources/FioriThemeManager/ThemeManager.swift
@restaurantt
Merge branch 'main-mergedDeprecatedDefinitions' of https://github.com…
9c3e899 
…/restaurantt/cloud-sdk-ios-fiori into main-mergedDeprecatedDefinitions
@restaurantt
Merge branch 'main' into main-mergedDeprecatedDefinitions
dcf2209
@restaurantt
fix: 🐛 [JIRA:0] ThemeManager merge color definitions should not be ca…
75e7e0e 
…lled frequently
@restaurantt restaurantt changed the title fix: 🐛 [JIRA:0] ThemeManager merge color definitions func to static variable fix: 🐛 [JIRA:0] ThemeManager merge color definitions should not be called frequently Jun 21, 2024
@restaurantt
Copy link
Contributor Author

restaurantt commented Jun 21, 2024 •
edited
Loading

What's the point of this PR?

when tableView is scrolling, func mergedDeprecatedDefinitions be called too many times and causes scrolling not smooth

@restaurantt
Copy link
Contributor Author

restaurantt commented Jun 24, 2024 •
edited
Loading

When I fixed internal project JIRA: IOSSDKBUG-220 Cards TableView scrolling is not smooth.
I use "Instruments" to watch why Cards TableView scrolling is not smooth. The result shows func mergedDeprecatedDefinitions in ThemeManager costs most time, especially the "while do merge" in mergedDeprecatedDefinitions . Look into the code, it merges the color by sdk version. and never changed because sdk version is fixed. So I use a variable to store the merged result.
I found this issue exists in this project, so create this pr.
instrument screenshot

@dyongxu
Copy link
Contributor

dyongxu commented Jun 24, 2024

@billzhou0223 Do you have some requested change to be addressed by Jianjun ? I am not able to find the request.

@billzhou0223
Copy link
Contributor

@billzhou0223 Do you have some requested change to be addressed by Jianjun ? I am not able to find the request.

My comments were for this commit 435caad. He updated the implementation in the latest commit and it looks ok now.

@dyongxu dyongxu merged commit fb2d496 into SAP:main Jun 25, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billzhou0223 billzhou0223 billzhou0223 approved these changes

@dyongxu dyongxu dyongxu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@restaurantt @dyongxu @billzhou0223