Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 🎸 [JIRA:IOSSDKBUG-5] add variables to ChartLabelAttribute #692

Merged
merged 3 commits into from
May 23, 2024

Conversation

hengyi-zhang
Copy link
Contributor

@hengyi-zhang hengyi-zhang commented May 20, 2024

add two variables(font and backgroundColor) to ChartLabelAttributes, for user to custom chart label attributes conveniently

@hengyi-zhang hengyi-zhang requested a review from a team as a code owner May 20, 2024 03:22
@hengyi-zhang hengyi-zhang requested review from billzhou0223 and removed request for a team May 20, 2024 03:22
Copy link

cla-assistant bot commented May 20, 2024

CLA assistant check
All committers have signed the CLA.

Sources/FioriCharts/Charts/Common/AxisTitle.swift Outdated Show resolved Hide resolved
Sources/FioriCharts/Charts/Common/XAxisView.swift Outdated Show resolved Hide resolved
Sources/FioriCharts/Charts/Common/AxisTitle.swift Outdated Show resolved Hide resolved
Sources/FioriCharts/Model/ChartLabelAttributes.swift Outdated Show resolved Hide resolved
@hengyi-zhang hengyi-zhang force-pushed the fix/IOSSDKBUG-5 branch 4 times, most recently from 440e8b0 to 851b3be Compare May 21, 2024 05:42
add two variables(font and backgroundColor) to ChartLabelAttributes, for
user to custom chart label attributes conveniently
@billzhou0223 billzhou0223 merged commit 777008e into SAP:main May 23, 2024
11 checks passed
hengyi-zhang added a commit to hengyi-zhang/cloud-sdk-ios-fiori that referenced this pull request Jun 24, 2024
add two variables(font and backgroundColor) to ChartLabelAttributes, for
user to custom chart label attributes conveniently

✅ Closes: SAP#692
hengyi-zhang added a commit to hengyi-zhang/cloud-sdk-ios-fiori that referenced this pull request Jun 24, 2024
add two variables(font and backgroundColor) to ChartLabelAttributes, for
user to custom chart label attributes conveniently

✅ Closes: SAP#692
hengyi-zhang added a commit to hengyi-zhang/cloud-sdk-ios-fiori that referenced this pull request Jun 24, 2024
add two variables(font and backgroundColor) to ChartLabelAttributes, for
user to custom chart label attributes conveniently

✅ Closes: SAP#692
dyongxu pushed a commit that referenced this pull request Jun 24, 2024
add two variables(font and backgroundColor) to ChartLabelAttributes, for
user to custom chart label attributes conveniently

✅ Closes: #692
dyongxu pushed a commit that referenced this pull request Jun 24, 2024
add two variables(font and backgroundColor) to ChartLabelAttributes, for
user to custom chart label attributes conveniently

✅ Closes: #692
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants