feat: 🎸 jira 2286 sort & filter for SwiftUI project #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A SwiftUI component for configuration criteria of performing sorting and filter. SortFilterMenu and SortFilterFullCFG are provided. ✅ Closes: 1
CharlesXu0488
requested review from
billzhou0223,
shengxu7,
dyongxu and
janhuachu
and removed request for
a team and
billzhou0223
A SwiftUI component for configuration criteria of performing sorting and filter. SortFilterMenu and SortFilterFullCFG are provided. ✅ Closes: 1
A SwiftUI component for configuration criteria of performing sorting and filter. SortFilterMenu and SortFilterFullCFG are provided. ✅ Closes: 1
CharlesXu0488
force-pushed
the
HCPSDKFIORIUIKIT-2286
branch
from
c37aeea
to
84cf550
Compare
billzhou0223
requested changes
Nov 1, 2023
Apps/Examples/Examples/FioriSwiftUICore/SortFilter/SortFilterExample.swift
Outdated
Show resolved
Hide resolved
Apps/Examples/Examples/FioriSwiftUICore/SortFilter/SortFilterExample.swift
Outdated
Show resolved
Hide resolved
Apps/Examples/Examples/FioriSwiftUICore/SortFilter/SortFilterExample.swift
Outdated
Show resolved
Hide resolved
Apps/Examples/Examples/FioriSwiftUICore/SortFilter/SortFilterExample.swift
Outdated
Show resolved
Hide resolved
Apps/Examples/Examples/FioriSwiftUICore/SortFilter/SortFilterExample.swift
Outdated
Show resolved
Hide resolved
Sources/FioriSwiftUICore/Views/SortFilter/SortFilterItemTitle.swift
Outdated
Show resolved
Hide resolved
Sources/FioriSwiftUICore/Views/SortFilter/SortFilterStyle.swift
Outdated
Show resolved
Hide resolved
billzhou0223
approved these changes
Nov 6, 2023
dyongxu
approved these changes
Nov 7, 2023
…d-sdk-ios-fiori into HCPSDKFIORIUIKIT-2286
![hound[bot]](https://github.com/avatars/in/3598?s=60&v=4){kind=small}
| typealias LeftIcon = EmptyModifier | ||
| typealias LeftIconCumulative = EmptyModifier | ||
| typealias Title = EmptyModifier | ||
| typealias TitleCumulative = EmptyModifier |
There was a problem hiding this comment.
Nesting Violation: Types should be nested at most 1 level deep (nesting)
| enum FilterFeedbackBarButton { | ||
| typealias LeftIcon = EmptyModifier | ||
| typealias LeftIconCumulative = EmptyModifier | ||
| typealias Title = EmptyModifier |
There was a problem hiding this comment.
Nesting Violation: Types should be nested at most 1 level deep (nesting)
| extension Fiori { | ||
| enum FilterFeedbackBarButton { | ||
| typealias LeftIcon = EmptyModifier | ||
| typealias LeftIconCumulative = EmptyModifier |
There was a problem hiding this comment.
Nesting Violation: Types should be nested at most 1 level deep (nesting)
|
|
||
| extension Fiori { | ||
| enum FilterFeedbackBarButton { | ||
| typealias LeftIcon = EmptyModifier |
There was a problem hiding this comment.
Nesting Violation: Types should be nested at most 1 level deep (nesting)
|
|
||
| extension Fiori { | ||
| enum FilterFeedbackBar { | ||
| typealias Items = EmptyModifier |
There was a problem hiding this comment.
Nesting Violation: Types should be nested at most 1 level deep (nesting)
| extension Fiori { | ||
| enum FilterFeedbackBarItem { | ||
| typealias LeftIcon = EmptyModifier | ||
| typealias LeftIconCumulative = EmptyModifier |
There was a problem hiding this comment.
Nesting Violation: Types should be nested at most 1 level deep (nesting)
|
|
||
| extension Fiori { | ||
| enum FilterFeedbackBarItem { | ||
| typealias LeftIcon = EmptyModifier |
There was a problem hiding this comment.
Nesting Violation: Types should be nested at most 1 level deep (nesting)
| typealias ResetAction = EmptyModifier | ||
| typealias ResetActionCumulative = EmptyModifier | ||
| typealias ApplyAction = EmptyModifier | ||
| typealias ApplyActionCumulative = EmptyModifier |
There was a problem hiding this comment.
Nesting Violation: Types should be nested at most 1 level deep (nesting)
| typealias CancelActionCumulative = EmptyModifier | ||
| typealias ResetAction = EmptyModifier | ||
| typealias ResetActionCumulative = EmptyModifier | ||
| typealias ApplyAction = EmptyModifier |
There was a problem hiding this comment.
Nesting Violation: Types should be nested at most 1 level deep (nesting)
| typealias CancelAction = EmptyModifier | ||
| typealias CancelActionCumulative = EmptyModifier | ||
| typealias ResetAction = EmptyModifier | ||
| typealias ResetActionCumulative = EmptyModifier |
There was a problem hiding this comment.
Nesting Violation: Types should be nested at most 1 level deep (nesting)
MarcoEidinger
added a commit
that referenced
this pull request
Nov 17, 2023
* 'main' of github.com:SAP/cloud-sdk-ios-fiori: fix: 🐛 [bcp: 0] remove background in ObjectHeader (#614) docs: ✏️ build documentation with DocC and host on swiftpackageindex.com (#613) chore: 🤖 refactor FioriIcon and support accessing cgImage through Image (#612) feat: 🎸 jira 2286 sort & filter for SwiftUI project (#606) fix: 🐛 [bcp: 2370136916] fix width mode for DimensionSelector (#610) feat: [JIRA: HCPSDKFIORIUIKIT-2444] Update to include more icons feat: [JIRA: HCPSDKFIORIUIKIT-2444] Update to include more icons chore: 🤖 update CI job for watchOS to use xcode 15 (#609) chore: 🤖 run CI job on macos-13 and xcode 15.0 (#608) feat: [JIRA: HCPSDKFIORIUIKIT-2444] Update to include more icons feat: [JIRA: HCPSDKFIORIUIKIT-2444] Update to include more icons feat: 🎸 [JIRA: HCPSDKFIORIUIKIT-2224] New FioriButtonStyle support (#603) feat: 🎸 [JIRA: HCPSDKFIORIUIKIT-2444] Update to include more icons feat: 🎸 [JIRA: HCPSDKFIORIUIKIT-2444] Update to include more icons feat: [JIRA: HCPSDKFIORIUIKIT-2444] Update to include more icons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A SwiftUI component for configuration criteria of performing sorting and filter. SortFilterMenu and SortFilterFullCFG are provided.
✅ Closes: 1