Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency between hash_into function names #462

Open
brxken128 opened this issue Sep 14, 2023 · 0 comments
Open

Inconsistency between hash_into function names #462

brxken128 opened this issue Sep 14, 2023 · 0 comments

Comments

@brxken128
Copy link

There's multiple differently named functions that all do the same thing - hash a password into a buffer:

  • argon2: .hash_password_into()
  • balloon-hash: .hash_into()
  • bcrypt-pbkdf: .finalize_into() (this one is understandable as it can be incremental)
  • scrypt: it's the only option available, via scrypt()
  • sha-crypt: does not provide the functionality at all

I personally think the easiest solution would be to rename balloon-hash' .hash_into() into .hash_password_into(), and although it'd be a breaking change it would unify the function names a little more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant