Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean code documentation section names and implement a checkpatch.pl check for it #1110

Open
ojeda opened this issue Sep 1, 2024 · 3 comments
Labels
• docs Related to `Documentation/rust/`, `samples/`, generated docs, doctests, typos... good first issue Good for newcomers

Comments

@ojeda
Copy link
Member

ojeda commented Sep 1, 2024

We prefer plurals when writing code documentation sections: # Examples, # Invariants, # Guarantees and # Panics, so that it is consistent and so that one can add more examples without having to change the section name.

At the time of writing, there are a few instances that should be cleaned up. In another patch, a checkpatch.pl cheek should be added to avoid adding more cases.

Please note that the checkpatch.pl maintainers will need to agree to the change.


This requires submitting a proper patch to the LKML and the Rust for Linux mailing list. Please recall to test your changes (including generating the documentation if changed, running the Rust doctests if changed, etc.), to use a proper title for the commit, to sign your commit under the Developer's Certificate of Origin and to add a Suggested-by: tag and a Link: tag to this issue. Please see https://rust-for-linux.com/contributing for details.

Please take this issue only if you are new to the kernel development process and you would like to use it as a test to submit your first patch to the kernel. Please do not take it if you do not plan to make other contributions to the kernel.

@ojeda ojeda added • docs Related to `Documentation/rust/`, `samples/`, generated docs, doctests, typos... good first issue Good for newcomers labels Sep 1, 2024
@paddymills
Copy link

Never written perl before, but I'll give this one a try.

Is it enough to consider all plurals to be words that end in 's'?

@ojeda
Copy link
Member Author

ojeda commented Sep 5, 2024

I would probably just do it case-by-case, i.e. catch the wrong singulars that we know about, such as # Example, so that we avoid false positives.

@paddymills
Copy link

I put a message in zulip regarding this.

Basically, the checkpatch.pl kernel patch for this is being held up and noted as possibly an "overly trivial addition."

So, I am wondering if there is anything I should do different? Would adding more stylistic checks to checkpatch.pl help (if there are some to be found) or would that not be a good idea? Is there another tool that would be a better fit for these checks?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
• docs Related to `Documentation/rust/`, `samples/`, generated docs, doctests, typos... good first issue Good for newcomers
Development

Successfully merging a pull request may close this issue.

2 participants