Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds sytem test 2 notebook #1402

Merged
merged 1 commit into from
Jun 5, 2023
Merged

Adds sytem test 2 notebook #1402

merged 1 commit into from
Jun 5, 2023

Conversation

saurav-c
Copy link
Contributor

@saurav-c saurav-c commented Jun 2, 2023

Describe your changes and why you are making these changes

This PR adds the notebook used for system testing 2 - medium data and simple model on a k8s compute resource.

Related issue number (if any)

ENG 2826

Loom demo (if any)

Checklist before requesting a review

  • I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
  • I have performed a self-review of my code.
  • I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
  • If this is a new feature, I have added unit tests and integration tests.
  • I have run the integration tests locally and they are passing.
  • I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
  • All features on the UI continue to work correctly.
  • Added one of the following CI labels:
    • run_integration_test: Runs integration tests
    • skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@saurav-c saurav-c added the skip_integration_test Skips required integration test (only documentation/UI changes) label Jun 2, 2023
@saurav-c saurav-c merged commit 1a90d1d into main Jun 5, 2023
@saurav-c saurav-c deleted the eng-2826 branch June 5, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip_integration_test Skips required integration test (only documentation/UI changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants