Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ondemand k8s showing aws icon rather than k8s #1391

Merged
merged 1 commit into from
May 31, 2023
Merged

Conversation

likawind
Copy link
Contributor

@likawind likawind commented May 31, 2023

Describe your changes and why you are making these changes

This PR fixed the issue where we are showing aws icon rather than k8s. This is introduced in #1380

Related issue number (if any)

Loom demo (if any)

Verified the icon is correct and the add resource dialog still showing AWS:
Screenshot 2023-05-30 at 5 57 31 PM
Screenshot 2023-05-30 at 5 53 22 PM

Checklist before requesting a review

  • I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
  • I have performed a self-review of my code.
  • I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
  • If this is a new feature, I have added unit tests and integration tests.
  • I have run the integration tests locally and they are passing.
  • I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
  • All features on the UI continue to work correctly.
  • Added one of the following CI labels:
    • run_integration_test: Runs integration tests
    • skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

@likawind likawind requested a review from cw75 May 31, 2023 00:56
@likawind likawind added the skip_integration_test Skips required integration test (only documentation/UI changes) label May 31, 2023
@likawind likawind merged commit 1def56c into main May 31, 2023
@cw75 cw75 deleted the fix_aws_icon branch May 31, 2023 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip_integration_test Skips required integration test (only documentation/UI changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants