Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix default GCS store metadata value #1389

Merged
merged 1 commit into from
May 30, 2023
Merged

Fix default GCS store metadata value #1389

merged 1 commit into from
May 30, 2023

Conversation

likawind
Copy link
Contributor

@likawind likawind commented May 30, 2023 •
edited
Loading

Describe your changes and why you are making these changes

Default GCS for being used as metadata storage. https://github.com/aqueducthq/aqueduct/pull/1380/files#diff-c1f12a54b37e8b729377f7edfa3df5d38166dbc6bd9398b1555858776e420817 wrongly changed this default value to try to make it consistent with S3.

Related issue number (if any)

ENG-3050

Loom demo (if any)

Screenshot 2023-05-30 at 4 13 50 PM

  • Confirmed on dialog box.
  • Confirmed use_as_storage is true in server logs.

Checklist before requesting a review

  • I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
  • I have performed a self-review of my code.
  • I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
  • If this is a new feature, I have added unit tests and integration tests.
  • I have run the integration tests locally and they are passing.
  • I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
  • All features on the UI continue to work correctly.
  • Added one of the following CI labels:
    • run_integration_test: Runs integration tests
    • skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

@likawind likawind requested review from agiron123, cw75, jegonzal and jpurusho65 and removed request for jegonzal May 30, 2023 23:14
@likawind likawind added the skip_integration_test Skips required integration test (only documentation/UI changes) label May 30, 2023
@likawind likawind merged commit c715756 into main May 30, 2023
agiron123
agiron123 reviewed May 31, 2023
View reviewed changes
Copy link
Contributor

@agiron123 agiron123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@likawind likawind deleted the fix_gcs_metadata_value branch May 31, 2023 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agiron123 agiron123 agiron123 left review comments

@jpurusho65 jpurusho65 jpurusho65 approved these changes

@cw75 cw75 Awaiting requested review from cw75

Assignees
No one assigned
Labels
skip_integration_test Skips required integration test (only documentation/UI changes)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@likawind @agiron123 @jpurusho65