Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-3027: Require Integration Name #1360

Merged
merged 5 commits into from
May 30, 2023
Merged

Conversation

agiron123
Copy link
Contributor

@agiron123 agiron123 commented May 23, 2023

Describe your changes and why you are making these changes

This PR fixes an issue where integrations are able to be registered without a name field present on the UI.

Related issue number (if any)

ENG-3027

Loom demo (if any)

Before:
image

After fix:
image

Checklist before requesting a review

  • I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
  • I have performed a self-review of my code.
  • I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
  • If this is a new feature, I have added unit tests and integration tests.
  • I have run the integration tests locally and they are passing.
  • I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
  • All features on the UI continue to work correctly.
  • Added one of the following CI labels:
    • run_integration_test: Runs integration tests
    • skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

CHANGELOG.md Outdated Show resolved Hide resolved
@agiron123 agiron123 added the skip_integration_test Skips required integration test (only documentation/UI changes) label May 23, 2023
Copy link
Contributor

@likawind likawind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you check on GCS and GAR since they appears to have name fields already?

@agiron123
Copy link
Contributor Author

Thanks! Could you check on GCS and GAR since they appears to have name fields already?

Sure, i will check those integrations before merging

@agiron123 agiron123 force-pushed the eng-3027-require-integration-name branch from 60fcf92 to 80ba49e Compare May 30, 2023 22:42
@agiron123 agiron123 merged commit 1563f69 into main May 30, 2023
@agiron123 agiron123 deleted the eng-3027-require-integration-name branch May 30, 2023 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip_integration_test Skips required integration test (only documentation/UI changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants