Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where bigquery extracts fail due to missing import #1359

Merged
merged 1 commit into from
May 23, 2023

Conversation

kenxu95
Copy link
Contributor

@kenxu95 kenxu95 commented May 23, 2023

Describe your changes and why you are making these changes

Description here: https://linear.app/aqueducthq/issue/ENG-3026/aqueduct-install-bigquery-is-not-sufficient-for-bigquery-extracts-to

What the PR does:

  • Better (or at least more consistent) error message if it doesn't exist:
image - Also adds `db-dtypes` to the `aqueduct install bigquery` command.

Related issue number (if any)

ENG-3026

Loom demo (if any)

Checklist before requesting a review

  • I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
  • I have performed a self-review of my code.
  • I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
  • If this is a new feature, I have added unit tests and integration tests.
  • I have run the integration tests locally and they are passing.
  • I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
  • All features on the UI continue to work correctly.
  • Added one of the following CI labels:
    • run_integration_test: Runs integration tests
    • skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

@kenxu95 kenxu95 requested a review from saurav-c May 23, 2023 22:10
@kenxu95 kenxu95 added the skip_integration_test Skips required integration test (only documentation/UI changes) label May 23, 2023
@kenxu95 kenxu95 merged commit e4ee310 into main May 23, 2023
@kenxu95 kenxu95 deleted the fix_bigquery_extract_error branch May 23, 2023 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip_integration_test Skips required integration test (only documentation/UI changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants