Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back optional flow_id and flow_name arguments #1350

Merged
merged 1 commit into from
May 22, 2023

Conversation

jpurusho65
Copy link
Contributor

Describe your changes and why you are making these changes

Mainly for backward compatibility. Using them shows Deprecated warning to end user.

Related issue number (if any)

ENG-3007

Loom demo (if any)

Checklist before requesting a review

  • I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
  • I have performed a self-review of my code.
  • I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
  • If this is a new feature, I have added unit tests and integration tests.
  • I have run the integration tests locally and they are passing.
  • I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
  • All features on the UI continue to work correctly.
  • Added one of the following CI labels:
    • run_integration_test: Runs integration tests
    • skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

@jpurusho65 jpurusho65 requested a review from kenxu95 May 22, 2023 21:38
Copy link
Contributor

@kenxu95 kenxu95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine for now. I was thinking we should just error but this should work too. Just a request to make the linear task to deprecate these two fields and link them in the code.

sdk/aqueduct/client.py Outdated Show resolved Hide resolved
sdk/aqueduct/client.py Show resolved Hide resolved
@kenxu95
Copy link
Contributor

kenxu95 commented May 22, 2023

Can you paste a screenshot as to what this deprecation warning looks like?

Mainly for backward compatibility. Using them shows
Deprecated warning to end user.
@jpurusho65 jpurusho65 force-pushed the eng-3007-add-flow_id-and-flow_name-arguments-back branch from 548d4cd to 756e442 Compare May 22, 2023 22:37
@jpurusho65 jpurusho65 requested review from kenxu95 and removed request for kenxu95 May 22, 2023 22:38
@jpurusho65
Copy link
Contributor Author

Can you paste a screenshot as to what this deprecation warning looks like?

Screen Shot 2023-05-22 at 15 46 02 PM

@jpurusho65 jpurusho65 requested a review from kenxu95 May 22, 2023 22:47
Copy link
Contributor

@kenxu95 kenxu95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, screenshot looks good. Thanks!

@jpurusho65 jpurusho65 added the run_integration_test Triggers integration tests label May 22, 2023
@jpurusho65 jpurusho65 merged commit b4cb1bb into main May 22, 2023
@jpurusho65 jpurusho65 deleted the eng-3007-add-flow_id-and-flow_name-arguments-back branch May 22, 2023 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run_integration_test Triggers integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants