Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge id and name arguments to one field #1325

Merged
merged 1 commit into from
May 22, 2023

Conversation

jpurusho65
Copy link
Contributor

Describe your changes and why you are making these changes

The Flow API had 2 distinct arguments for UUID and Name. This PR merges both of them to one argument as
a Union[uuid, str]

Related issue number (if any)

ENG-2760

Loom demo (if any)

Checklist before requesting a review

  • [ x] I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
  • [ x] I have performed a self-review of my code.
  • I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
  • If this is a new feature, I have added unit tests and integration tests.
  • [x ] I have run the integration tests locally and they are passing.
  • [x ] I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
  • All features on the UI continue to work correctly.
  • Added one of the following CI labels:
    • run_integration_test: Runs integration tests
    • skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

@jpurusho65 jpurusho65 requested a review from kenxu95 May 16, 2023 00:19
Copy link
Contributor

@kenxu95 kenxu95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for fixing this in multiple places!

@jpurusho65 jpurusho65 force-pushed the eng-2760-merge-id-and-name-arguments-into-one-for branch from 8a4775e to d1a9bf5 Compare May 22, 2023 04:20
@jpurusho65 jpurusho65 added the run_integration_test Triggers integration tests label May 22, 2023
@jpurusho65 jpurusho65 merged commit b47619a into main May 22, 2023
@kenxu95 kenxu95 deleted the eng-2760-merge-id-and-name-arguments-into-one-for branch May 22, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run_integration_test Triggers integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants