-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix generated docstrings when viewing resource methods in Jupyter #1315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsubbaraj-spiral
approved these changes
May 15, 2023
likawind
added a commit
that referenced
this pull request
May 17, 2023
commit e1fd9d7 Merge: 370665e 2fad420 Author: Wei Chen <wei@aqueducthq.com> Date: Wed May 17 14:19:11 2023 -0700 Merge branch 'eng-2699-m1-refactor-wf-detail-pages-to-use-new' into eng-2699-m1-refactor-wf-detail-pages-to-use-new-2 commit 2fad420 Merge: b4485f4 676e81a Author: Wei Chen <wei@aqueducthq.com> Date: Wed May 17 14:06:26 2023 -0700 Merge branch 'eng-2699-m1-refactor-wf-detail-pages-to-use-new' of https://github.com/aqueducthq/aqueduct into eng-2699-m1-refactor-wf-detail-pages-to-use-new commit b4485f4 Author: Wei Chen <wei@aqueducthq.com> Date: Mon Apr 24 15:43:51 2023 -0700 rebase commit d3a2669 Merge: e60ac09 18011cb Author: Wei Chen <wei@aqueducthq.com> Date: Wed May 17 14:04:32 2023 -0700 Merge branch 'eng-2712-m1-migrate-wf-edit-trigger-endpoints-to' into eng-2943-investigate-result-content-route-tests commit 18011cb Merge: ec515cf 8cb356c Author: Wei Chen <wei@aqueducthq.com> Date: Wed May 17 14:02:47 2023 -0700 Merge branch 'eng-2847-m1-implement-wfiddags-endpoint-with' into eng-2712-m1-migrate-wf-edit-trigger-endpoints-to commit 8cb356c Merge: ec94379 b3946a4 Author: Wei Chen <wei@aqueducthq.com> Date: Wed May 17 14:02:23 2023 -0700 Merge branch 'main' of https://github.com/aqueducthq/aqueduct into eng-2847-m1-implement-wfiddags-endpoint-with commit 676e81a Author: Wei Chen <wei@aqueducthq.com> Date: Mon Apr 24 15:43:51 2023 -0700 rebase commit ec94379 Author: Wei Chen <wei@aqueducthq.com> Date: Wed May 17 13:28:38 2023 -0700 comments commit b3946a4 Author: kenxu95 <kenxu@aqueducthq.com> Date: Wed May 17 10:19:11 2023 -0700 Move any overflow rows on the details header fields into an additional column (#1322) commit e60ac09 Author: Wei Chen <wei@aqueducthq.com> Date: Tue May 16 20:04:49 2023 -0700 fix commit ec515cf Merge: 1d0482a f81c065 Author: Wei Chen <wei@aqueducthq.com> Date: Tue May 16 17:37:04 2023 -0700 Merge branch 'eng-2847-m1-implement-wfiddags-endpoint-with' into eng-2712-m1-migrate-wf-edit-trigger-endpoints-to commit f81c065 Author: Wei Chen <wei@aqueducthq.com> Date: Tue May 16 17:34:45 2023 -0700 lint commit 1d0482a Author: Wei Chen <wei@aqueducthq.com> Date: Tue May 16 17:29:44 2023 -0700 works commit 5ad5130 Author: Andre Giron <andre@aqueducthq.com> Date: Tue May 16 16:34:41 2023 -0700 ENG-2979: Fixes bigquery and gcs dialogs that were crashing after file uploads. (#1326) Co-authored-by: Andre Giron <andre@spiralai.co> commit 03aa76e Author: Andre Giron <andre@aqueducthq.com> Date: Tue May 16 16:33:35 2023 -0700 ENG-2979 S3 Dialog Validation Fixes (#1328) Co-authored-by: Andre Giron <andre@spiralai.co> commit f63c5f3 Author: kenxu95 <kenxu@aqueducthq.com> Date: Tue May 16 16:24:14 2023 -0700 Fix Snowflake save missing schema bug (#1331) commit a458ce6 Author: Wei Chen <wei@aqueducthq.com> Date: Tue May 16 15:27:52 2023 -0700 works commit f529c5f Author: Saurav Chhatrapati <saurav@aqueducthq.com> Date: Tue May 16 13:36:12 2023 -0400 Fixes cloudpickle serialization for Python 3.7 (#1324) commit c335fd5 Author: Saurav Chhatrapati <saurav@aqueducthq.com> Date: Tue May 16 12:15:48 2023 -0400 Adds error checking for whether big query dataset exists (#1319) commit d3521a4 Author: kenxu95 <kenxu@aqueducthq.com> Date: Mon May 15 20:58:16 2023 -0700 Add ability to parameterize the save operator (#1320) commit 942dec1 Author: kenxu95 <kenxu@aqueducthq.com> Date: Mon May 15 15:36:21 2023 -0700 [UI] Merge the Conda resource into the Aqueduct Server (#1311) commit ccf4e17 Author: Wei Chen <wei@aqueducthq.com> Date: Mon May 15 14:57:19 2023 -0700 [2/n] Adds gh actions to publish test pypi packages (#1262) commit fb67044 Author: kenxu95 <kenxu@aqueducthq.com> Date: Mon May 15 12:04:48 2023 -0700 Fix bug where duplicate fields showing in resource details dropdown (#1321) commit cfeeb2f Author: kenxu95 <kenxu@aqueducthq.com> Date: Mon May 15 11:45:31 2023 -0700 Fix generated docstrings when viewing resource methods in Jupyter (#1315) commit b544252 Author: eunice-chan <30596854+eunice-chan@users.noreply.github.com> Date: Fri May 12 21:26:55 2023 -0500 Eng 2884 test node routes (#1299) Co-authored-by: Eunice Chan <eunice@aqueducthq.com> Co-authored-by: Wei Chen <wei@aqueducthq.com> commit a8abb16 Author: Andre Giron <andre@aqueducthq.com> Date: Fri May 12 16:58:59 2023 -0700 Fixes broken storybook build (#1317) Co-authored-by: Andre Giron <andre@spiralai.co> commit d6ed5ca Author: kenxu95 <kenxu@aqueducthq.com> Date: Fri May 12 10:56:42 2023 -0700 Update the workflow "No Run" logo (#1312) commit c9fec70 Author: Chenggang Wu <cgwu0530@gmail.com> Date: Fri May 12 09:30:54 2023 -0700 README typo fix (#1313) commit b686014 Author: Andre Giron <andre@aqueducthq.com> Date: Thu May 11 12:49:53 2023 -0700 ENG-2767 react hook form submission (#1232) Co-authored-by: Andre Giron <andre@spiralai.co> Co-authored-by: Chenggang Wu <cgwu0530@gmail.com> Co-authored-by: kenxu95 <kenxu@aqueducthq.com> commit 86269ec Author: kenxu95 <kenxu@aqueducthq.com> Date: Thu May 11 12:09:42 2023 -0700 Add appropriate workflow count to our connected notification cards and details page (#1302) commit 7c75ad6 Author: kenxu95 <kenxu@aqueducthq.com> Date: Thu May 11 10:45:52 2023 -0700 Update the artifact storage card presentation to be consistent with the other data integrations (#1297) commit 4f9c227 Author: Andre Giron <andre@aqueducthq.com> Date: Wed May 10 16:55:23 2023 -0700 ENG_2960: Fix broken documentation link for Aqueduct demo resource. (#1306) Co-authored-by: Andre Giron <andre@spiralai.co> commit 6341917 Author: Andre Giron <andre@aqueducthq.com> Date: Wed May 10 16:28:23 2023 -0700 Release version 0.3.2 (#1307) Co-authored-by: Vikram Sreekanti <vsreekanti@gmail.com> Co-authored-by: Andre Giron <andre@spiralai.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and why you are making these changes
Simple bug fix that shows the docstring for even those methods using the @validate_is_connected() decorator.
Related issue number (if any)
ENG-2886
Loom demo (if any)
Checklist before requesting a review
python3 scripts/run_linters.py -h
for usage).run_integration_test
: Runs integration testsskip_integration_test
: Skips integration tests (Should be used when changes are ONLY documentation/UI)