Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename integrations to resources on the SDK and example notebooks #1276

Merged
merged 9 commits into from
May 3, 2023

Conversation

kenxu95
Copy link
Contributor

@kenxu95 kenxu95 commented May 3, 2023

Describe your changes and why you are making these changes

Doesn't cover everything, but it should cover all the user-facing parts that need to be renamed. The old client methods are not deleted. They still work, just with an error message..

Related issue number (if any)

ENG-2777

Loom demo (if any)

Checklist before requesting a review

  • I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
  • I have performed a self-review of my code.
  • I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
  • If this is a new feature, I have added unit tests and integration tests.
  • I have run the integration tests locally and they are passing.
  • I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
  • All features on the UI continue to work correctly.
  • Added one of the following CI labels:
    • run_integration_test: Runs integration tests
    • skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

@kenxu95 kenxu95 requested review from cw75, likawind and saurav-c May 3, 2023 04:56
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Contributor

@cw75 cw75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kenxu95 kenxu95 added the run_integration_test Triggers integration tests label May 3, 2023
@kenxu95 kenxu95 merged commit 3a793e4 into main May 3, 2023
@kenxu95 kenxu95 deleted the eng-2777-add-clientresource-to-the-sdk branch May 3, 2023 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run_integration_test Triggers integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants