[1/n] Allow pypi pkg version injection by splitting version into a separate file #1259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saurav-c
approved these changes
Apr 27, 2023
| @@ -6,6 +6,7 @@ | |||
| from aqueduct_executor.operators.utils.utils import time_it | |||
|
|
|||
| if __name__ == "__main__": | |||
| print("testing") | |||
likawind
added
the
skip_integration_test
agiron123
pushed a commit
that referenced
this pull request
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and why you are making these changes
This PR splits pypi package version into a separate file so that it's easier for us to inject dev version numbers in gh actions. Release repo updates: https://github.com/aqueducthq/release/pull/10
Related issue number (if any)
ENG-2854
Loom demo (if any)
Verified with pypi build that changing the file will change the version of the package.
Checklist before requesting a review
python3 scripts/run_linters.py -hfor usage).run_integration_test: Runs integration testsskip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)