Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase server setup timeouts in integration tests #1254

Merged
merged 1 commit into from
May 1, 2023

Conversation

likawind
Copy link
Contributor

Describe your changes and why you are making these changes

This PR increases server setup timeouts from 5 min to 7 min. Based on recent integration test failures, the current setup time appear to start reaching the boundary.

Installing collected packages: tomli, regex, pluggy, joblib, iniconfig, execnet, exceptiongroup, pytest, nltk, pytest-xdist
Successfully installed exceptiongroup-1.1.1 execnet-1.9.0 iniconfig-2.0.0 joblib-1.2.0 nltk-3.8.1 pluggy-1.0.0 pytest-7.3.1 pytest-xdist-3.2.1 regex-2023.3.23 tomli-2.0.1

Notice:  A new release of pip is available: 22.0.4 -> 23.1.2
Notice:  To update, run: pip install --upgrade pip

# We never reach the line that polls the server state

Error: The action has timed out.

Related issue number (if any)

Loom demo (if any)

Checklist before requesting a review

  • I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
  • I have performed a self-review of my code.
  • I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
  • If this is a new feature, I have added unit tests and integration tests.
  • I have run the integration tests locally and they are passing.
  • I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
  • All features on the UI continue to work correctly.
  • Added one of the following CI labels:
    • run_integration_test: Runs integration tests
    • skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

@likawind likawind added the skip_integration_test Skips required integration test (only documentation/UI changes) label Apr 27, 2023
@kenxu95 kenxu95 self-requested a review May 1, 2023 17:47
@saurav-c saurav-c merged commit dc25d6c into main May 1, 2023
@vsreekanti vsreekanti deleted the increase_test_timeout branch May 9, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip_integration_test Skips required integration test (only documentation/UI changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants