Fix isort in our code and automated linter #1227

kenxu95 · 2023-04-18T22:27:53Z

Describe your changes and why you are making these changes

We weren't checking this before, meaning someone with the wrong version of isort must have updated it recently?

I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
I have performed a self-review of my code.
I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
If this is a new feature, I have added unit tests and integration tests.
I have run the integration tests locally and they are passing.
I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
All features on the UI continue to work correctly.
Added one of the following CI labels:
- run_integration_test: Runs integration tests
- skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

agiron123 · 2023-04-18T23:19:25Z

What version of isort should we be using? I don't see any code in this PR which sets that version number.

kenxu95 · 2023-04-19T15:00:04Z

Pinned exact isort-version.

kenxu95 added 2 commits April 18, 2023 18:22

ready

3d891e6

done

41d3fb8

kenxu95 changed the title ~~Fix isort in our code and automated linear~~ Fix isort in our code and automated linter Apr 18, 2023

kenxu95 requested review from eunice-chan and hsubbaraj-spiral April 18, 2023 22:28

done

a50e18e

kenxu95 added the skip_integration_test Skips required integration test (only documentation/UI changes) label Apr 19, 2023

kenxu95 requested a review from agiron123 April 19, 2023 15:02

agiron123 approved these changes Apr 19, 2023

View reviewed changes

kenxu95 merged commit 93a8707 into main Apr 19, 2023

kenxu95 deleted the test_isort branch April 19, 2023 15:30