Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-2790 Set Default Tabs for Integrations Dialog #1207

Merged
merged 3 commits into from
Apr 13, 2023

Conversation

agiron123
Copy link
Contributor

@agiron123 agiron123 commented Apr 13, 2023

Describe your changes and why you are making these changes

This PR fixes JavaScript console errors related to integrations dialogs not having default tab values set.

It also fixes error messages related to using null instead of empty string when there is no value to be rendered in a text field (react prefers empty strings in our case)

Related issue number (if any)

ENG-2790

Loom demo (if any)

https://www.loom.com/share/a47669ed643f49a18dd31ea24d08a044

Checklist before requesting a review

  • I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
  • I have performed a self-review of my code.
  • I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
  • If this is a new feature, I have added unit tests and integration tests.
  • I have run the integration tests locally and they are passing.
  • I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
  • All features on the UI continue to work correctly.
  • Added one of the following CI labels:
    • run_integration_test: Runs integration tests
    • skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

@agiron123 agiron123 added the skip_integration_test Skips required integration test (only documentation/UI changes) label Apr 13, 2023
@agiron123 agiron123 requested a review from likawind April 13, 2023 20:45
Copy link
Contributor

@likawind likawind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@agiron123 agiron123 merged commit 1c98814 into main Apr 13, 2023
@agiron123 agiron123 deleted the eng-2790-integrations-dialog-default-tabs branch April 13, 2023 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip_integration_test Skips required integration test (only documentation/UI changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants