Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow more flexibility in the run_tests.py script #1192

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

kenxu95
Copy link
Contributor

@kenxu95 kenxu95 commented Apr 10, 2023

Describe your changes and why you are making these changes

It's pretty annoying that there are only a subset of the pytest flags implemented in run_tests.py. It would be much better just to pass any flags down to the pytest command, and have run_tests.py be a kind of convenience helper.

Related issue number (if any)

ENG-2766

Loom demo (if any)

Checklist before requesting a review

  • I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
  • I have performed a self-review of my code.
  • I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
  • If this is a new feature, I have added unit tests and integration tests.
  • I have run the integration tests locally and they are passing.
  • I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
  • All features on the UI continue to work correctly.
  • Added one of the following CI labels:
    • run_integration_test: Runs integration tests
    • skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

Copy link
Contributor

@hsubbaraj-spiral hsubbaraj-spiral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make sense to me!

@kenxu95 kenxu95 added the run_integration_test Triggers integration tests label Apr 11, 2023
@kenxu95 kenxu95 merged commit 867037f into main Apr 11, 2023
@kenxu95 kenxu95 deleted the eng-2766-allow-more-flexibility-in-the branch April 11, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run_integration_test Triggers integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants