Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eng 1986 warn user when there is a python version mismatch between server and client #1182

Merged
merged 8 commits into from
Apr 10, 2023

Conversation

eunice-chan
Copy link
Contributor

Describe your changes and why you are making these changes

Warn user when there is a python version mismatch between server and client as it may result in unexpected errors when running the workflow on the server.

Related issue number (if any)

ENG 1986

Loom demo (if any)

Commented out most of the warning display condition to show what is the warning. I don't have a Python version mismatch so it won't show otherwise.
image

Displays warning there is a mismatch but still allows the workflow to be published (as seen in the next line, there is a URL).

Checklist before requesting a review

  • I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
  • I have performed a self-review of my code.
  • I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
  • [N/A] If this is a new feature, I have added unit tests and integration tests.
  • I have run the integration tests locally and they are passing.
  • I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
  • [N/A] All features on the UI continue to work correctly.
  • Added one of the following CI labels:
    • run_integration_test: Runs integration tests
    • skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

@eunice-chan eunice-chan added the run_integration_test Triggers integration tests label Apr 7, 2023
Copy link
Contributor

@kenxu95 kenxu95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed the error message in your screenshot has the same version for client and server? We only want to print this warning when they mismatch right - was this just a demo oversight?

sdk/aqueduct/models/response_models.py Outdated Show resolved Hide resolved
sdk/aqueduct/client.py Outdated Show resolved Hide resolved
@eunice-chan
Copy link
Contributor Author

@kenxu95 Good eye! For purposes of demonstration, I removed the condition checking the values are different. When the condition is put back in place, the warning does not show up if there is no mismatch, as expected.

@eunice-chan eunice-chan merged commit fd150f8 into main Apr 10, 2023
@vsreekanti vsreekanti deleted the eng-1986-warn-user-when-there-is-a-python-version branch April 13, 2023 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run_integration_test Triggers integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants