Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds new example notebooks #1158

Merged
merged 1 commit into from
Apr 4, 2023
Merged

Adds new example notebooks #1158

merged 1 commit into from
Apr 4, 2023

Conversation

vsreekanti
Copy link
Contributor

Describe your changes and why you are making these changes

Adds recently developed example notebooks to examples directory.

Related issue number (if any)

Loom demo (if any)

Checklist before requesting a review

  • I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
  • I have performed a self-review of my code.
  • [N/A] I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
  • [N/A] If this is a new feature, I have added unit tests and integration tests.
  • [N/A] I have run the integration tests locally and they are passing.
  • [N/a] I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
  • [N/A] All features on the UI continue to work correctly.
  • Added one of the following CI labels:
    • run_integration_test: Runs integration tests
    • skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

@vsreekanti vsreekanti added the skip_integration_test Skips required integration test (only documentation/UI changes) label Mar 31, 2023
@vsreekanti vsreekanti requested review from kenxu95 and cw75 March 31, 2023 18:29
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Contributor

@kenxu95 kenxu95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How long do these notebooks take to run? Should we consider adding them to our GH actions?

@vsreekanti
Copy link
Contributor Author

The RoBERTa one takes about 10 minutes. The ImageNet one's a little longer — about 15-20 iirc.

@vsreekanti vsreekanti merged commit 90c6e37 into main Apr 4, 2023
@vsreekanti vsreekanti deleted the new-example-notebooks branch April 4, 2023 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip_integration_test Skips required integration test (only documentation/UI changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants