Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG 2707 MongoDB text consistency in Integration Connection Card #1157

Merged
merged 1 commit into from
Mar 31, 2023

Conversation

eunice-chan
Copy link
Contributor

Describe your changes and why you are making these changes

Uri --> URI
mongoDB --> MongoDB

Related issue number (if any)

ENG 2707

Loom demo (if any)

Before
Screen Shot 2023-03-31 at 9 04 23 AM

After
Screen Shot 2023-03-31 at 9 04 11 AM

Checklist before requesting a review

  • I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
  • I have performed a self-review of my code.
  • I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
  • [N/A] If this is a new feature, I have added unit tests and integration tests.
  • [N/A] I have run the integration tests locally and they are passing.
  • I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
  • All features on the UI continue to work correctly.
  • Added one of the following CI labels:
    • run_integration_test: Runs integration tests
    • skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

@eunice-chan eunice-chan added the skip_integration_test Skips required integration test (only documentation/UI changes) label Mar 31, 2023
Copy link
Contributor

@vsreekanti vsreekanti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@eunice-chan eunice-chan merged commit f8f29a3 into main Mar 31, 2023
jpurusho65 pushed a commit that referenced this pull request Apr 3, 2023
Co-authored-by: Eunice Chan <eunice@aqueducthq.com>
@vsreekanti vsreekanti deleted the eng-2707-fix-bug-with-field-names-on-mongodb branch April 4, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip_integration_test Skips required integration test (only documentation/UI changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants