Eng 2702 Implement v2 workflow metadata routes #1151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g-2698-m1-implement-v2-api-framework
eunice-chan
reviewed
Mar 30, 2023
There was a problem hiding this comment.
This is a deprecated handler, right? Is there some way we can differentiate it from the v2 handlers? Maybe either appending deprecated to this or v2 to the new ones.
There was a problem hiding this comment.
Yeah that's a good idea!
There was a problem hiding this comment.
Actually this file shouldn't be included, removed
saurav-c
approved these changes
Mar 31, 2023
…g-2702-m1-implement-workflow-metadata-routes
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
likawind
changed the base branch from
eng-2698-m1-implement-v2-api-framework
to
main
…g-2702-m1-implement-workflow-metadata-routes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and why you are making these changes
This PR implements 2 workflow metadata routes:
dag_getanddag_result_get. Besides following standard RTK boilerplate introduced in #1148 , we added a few adjustments:responsepackage so that it's easier to maintain 1-1 mapping against UI codesdeprecated.Related issue number (if any)
ENG-2702
Tests
Compiles
Manual QA WIP
Checklist before requesting a review
python3 scripts/run_linters.py -hfor usage).run_integration_test: Runs integration testsskip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)