Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(fuselage-hooks): usePosition fallback #588

Merged
merged 1 commit into from
Dec 14, 2021
Merged

fix(fuselage-hooks): usePosition fallback #588

merged 1 commit into from
Dec 14, 2021

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Dec 14, 2021

  • I have read the Contributing Guide
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have labeled the PR correctly with the related package
  • I have run Loki's visual regression tests (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Proposed changes (including videos or screenshots)

Issue(s)

Further comments

@ggazzo ggazzo requested a review from a team December 14, 2021 19:50
rique223
rique223 approved these changes Dec 14, 2021
View reviewed changes
Copy link
Contributor

@rique223 rique223 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ggazzo ggazzo merged commit 4662cf0 into develop Dec 14, 2021
@ggazzo ggazzo deleted the fix/usePosition branch December 14, 2021 20:35
This was referenced Sep 13, 2023
Closed
Merged
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rique223 rique223 rique223 approved these changes

Assignees
No one assigned
Labels
📦 fuselage-hooks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ggazzo @rique223