Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(message-parser): Fix Url and Escaped Markdown #537

Merged
merged 5 commits into from
Sep 18, 2021

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Sep 17, 2021

A brand new Gist

  • I have read the Contributing Guide
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have labeled the PR correctly with the related package
  • I have run Loki's visual regression tests (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Proposed changes (including videos or screenshots)

Issue(s)

closes #455
and should close RocketChat/Rocket.Chat#8989
closes RocketChat/Rocket.Chat#21184
closes RocketChat/Rocket.Chat#7707
closes RocketChat/Rocket.Chat#21184
closes RocketChat/Rocket.Chat#5218

Further comments

@ggazzo ggazzo requested a review from a team September 17, 2021 15:29
@ggazzo ggazzo merged commit bc0cbce into develop Sep 18, 2021
@ggazzo ggazzo deleted the fix/markdown-url-escape branch September 18, 2021 04:32
@github-actions github-actions bot mentioned this pull request Nov 8, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant