Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation not showing for Hide_Livechat_Warning #8263

Closed
geekgonecrazy opened this issue Sep 23, 2017 · 7 comments
Closed

Translation not showing for Hide_Livechat_Warning #8263

geekgonecrazy opened this issue Sep 23, 2017 · 7 comments

Comments

@geekgonecrazy
Copy link
Contributor

Description:

image

Server Setup Information:

  • Version of Rocket.Chat Server: 0.59.0-rc.8
    Community Server

Steps to Reproduce:

  1. Click to hide livechat

Expected behavior:

Should show translation message

Actual behavior:

Shows Hide_Livechat_Warning

Relevant logs:

None

@geekgonecrazy
Copy link
Contributor Author

@karlprieb not sure why this isn't showing for this one. Seems to show for the rest of the hide / leave

@engelgabriel engelgabriel added this to the 0.59.0-rc.9 milestone Sep 23, 2017
@karlprieb
Copy link
Contributor

@geekgonecrazy here is working. Could you wipe your cache and test again?

image

@sampaiodiego
Copy link
Member

sampaiodiego commented Sep 25, 2017

it might be something related to our build cache..

I would suggest to not use travis cache on tag builds to avoid this kind of error, @RocketChat/core what do you think?

As you can see the translation is there.

@geekgonecrazy
Copy link
Contributor Author

This sounds right. Building after clearing meteor build cache it works right. But going through travis it doesn't. Is there a way to have just the translation stuff invalidated in the build cache?

@engelgabriel
Copy link
Member

https://forums.meteor.com/t/weird-behaviour-of-tap-i18n-package/15454/10

Thanks for that info! At least this is a better workaround than doing a full meteor reset, as I am doing now.

@geekgonecrazy
Copy link
Contributor Author

so looks like just deleting .meteor/bundler-cache might do the trick

@engelgabriel
Copy link
Member

The issue is that the i18n package is the package that takes longer to build :(

If we are building it on every PR, they will all take a lot longer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants