Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incoming Webhooks post without username and avatar the first time they join a channel #1705

Closed
Morgul opened this issue Dec 19, 2015 · 3 comments

Comments

@Morgul
Copy link
Contributor

Morgul commented Dec 19, 2015

The first time the user for an Incoming Webhook posts a message, it posts without an avatar or username:

screen shot 2015-12-18 at 9 45 24 pm

That is a join message, the first post ("Testing!") and a second post ("More tests!"). The styling also seems broken, but probably because the elements are missing.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@engelgabriel
Copy link
Member

Thank for the report @Morgul

The grouping of the message should be now fixed, can you test that?

I dont think we would/should be able to support the join message with the alias tho.

The bot will only join the channel once anyway. And if is that important to be "Grevious" from the JOIN message, than you can always create the "Grevious" bot.

@Morgul
Copy link
Contributor Author

Morgul commented Dec 22, 2015

@engelgabriel That sounds reasonable to me; the join message should be the bot's default name and avatar.

I will test this again tomorrow, and report back.

@Morgul
Copy link
Contributor Author

Morgul commented Dec 23, 2015

I can confirm this is now working with the latest code on develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants