Modas2021_PRIME models added #57
Conversation
robustbench/model_zoo/cifar10.py
Outdated
| @@ -341,6 +340,21 @@ def forward(self, x): | |||
| return torch.mean(torch.stack(out_list),dim=0) | |||
|
|
|||
|
|
|||
| class Modas2021PRIME_ResNet18(ResNet): | |||
There was a problem hiding this comment.
i'd rename it without _ for the sake of consistency with the existing models (e.g., like here), i.e. Modas2021PRIME_ResNet18 -> Modas2021PRIMEResNet18
robustbench/model_zoo/cifar100.py
Outdated
| @@ -185,6 +186,21 @@ def forward(self, x): | |||
|
|
|||
| return torch.mean(torch.stack(out_list),dim=0) | |||
|
|
|||
|
|
|||
| class Modas2021PRIME_RN18_100(ResNet): | |||
There was a problem hiding this comment.
also for the same reason here Modas2021PRIME_RN18_100 -> Modas2021PRIMEResNet18 (and without 100 which, i guess, signifies the number of classes? but it's anyway the same for all CIFAR-100 models, so there is no need to mention it in the class name)
robustbench/model_zoo/cifar100.py
Outdated
| @@ -381,6 +397,10 @@ def forward(self, x): | |||
| lambda: WideResNet(num_classes=100, depth=34, sub_block1=True), | |||
| 'gdrive_id': '1-9GAld_105-jWBLXL73btmfOCwAqvz7Y' | |||
| }), | |||
| ('Modas2021PRIME_RN18_100', { | |||
There was a problem hiding this comment.
and also i'd remove here _100 and in the json name as well (for the same reason as above).
other than that, looks good to me! thanks a lot!
There was a problem hiding this comment.
Updated, let me know if somethings missing.
Done, was doing it, in that time you added the comment. |
|
Thanks, LGTM now! |
|
Could you please still update the readme with the model IDs? The rest looks good to me too, thanks! |
No description provided.