Updat MongoDBBridge for timestamp. #227
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Sanic, I pulled a request. |
Sanic
reviewed
Mar 23, 2022
|
|
||
| n_.getParam("ts",time_stamp); // getting the value of "ts" from the command arg and store in time_stamp. | ||
| n_.deleteParam("ts"); // deleting the "ts" variable. | ||
|
|
||
| MEASURE_TIME; |
There was a problem hiding this comment.
MEASURE_TIME should always be at the beginning of a method
| auto it= std::find(frames.begin(), frames.end(), time_stamp); // finding if the queued timestamp is in the frames vector | ||
|
|
||
| if(it== frames.end()){ | ||
| outWarn("Timestamp Queried is not in the frame or Timestamp Query not enabled"); |
There was a problem hiding this comment.
This is triggered on every iteration when the ts parameter is not set by the user.
Could you please change the method so that it checks if the timestamp parameter is set and only then do the required steps?
|
I think that it would also be reasonable to check that if the timestamp parameter is set and no frame for this timestamp exists, that you then already return false in line 98. Basically like you do it in Line 113. |
|
Hi @Sanic, Kindly have a look at the updated MongoDBBridge.cpp file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.