write a checksum file after downloading and use that when the file exists #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 13, 2013 12:06
Only write the checksum when we are Nexus or S3 - remote_file will do the rest. Fast return a value when the cached checksum exists. otherwise check the Nexus server (for Nexus) or check the resource's checksum (S3 or remote_file)
|
🐩 |
|
+1 as far as my limited knowledge on this cookbook goes. |
KAllan357
added a commit
that referenced
this pull request
Nov 19, 2013
write a checksum file after downloading and use that when the file exists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we download an artifact_file, we should write a checksum for that file to the file_cache_path. That way, once a file has been downloaded, we only need to check the written file to ensure the local file hasn't changed - Nexus downloads in particular are affected because we'll no longer need to keep asking the Nexus server for a SHA1.