After download callback for artifact_package #107
Conversation
|
Do you think this would be helpful if it was exposed to the I think you'd just want to pass it through on the Can this have tests added? I think the test could be added in |
the original code assumed whatever value after the extension is the version. This is not necessary true since the classifier can come between the version and extension.
- included integration tests
| # @param name [Symbol] the name of the proc to execute | ||
| # | ||
| # @return [void] | ||
| def execute_run_proc(from, resource, name) |
There was a problem hiding this comment.
Is it possible to remove the from parameter and use #{__FILE__} to get us that extra bit of logging?
It might make it cleaner to have this method be called run_proc and then remove the private methods on the other classes.
There was a problem hiding this comment.
I don't think you can if you want to preserve the same style of logging before.
…r' into after_download
Conflicts:
providers/deploy.rb
|
👍 |
After download callback for artifact_package
Call the after_download proc if an artifact has been downloaded, otherwise it's not called.