Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actors with matching filenames don't spawn correctly #3166

Open
CuriousMike56 opened this issue Jul 17, 2024 · 1 comment · May be fixed by #3171
Open

Actors with matching filenames don't spawn correctly #3166

CuriousMike56 opened this issue Jul 17, 2024 · 1 comment · May be fixed by #3171

Comments

@CuriousMike56
Copy link
Collaborator

If you have multiple zips containing truck files with the same filenames (common with private mods) only one will spawn correctly.
image
The first mod in the selector spawns OK, any duplicate filenames will fail to load all assets (meshes, materials etc):
screenshot_2024-07-17_16-52-32_1

16:52:08: Ogre::ItemIdentityException::ItemIdentityException: Cannot locate a resource group called '' in ResourceGroupManager::resourceExists at C:\Users\runneradmin\.conan2\p\b\ogre30c15d995aab6a\b\OgreMain\src\OgreResourceGroupManager.cpp (line 1566)
16:52:08: [RoR|Actor|Error] (Keyword: managedmaterials) Ogre::ItemIdentityException::ItemIdentityException: Cannot locate a resource group called '' in ResourceGroupManager::resourceExists at C:\Users\runneradmin\.conan2\p\b\ogre30c15d995aab6a\b\OgreMain\src\OgreResourceGroupManager.cpp (line 1566)
16:52:08: Ogre::ItemIdentityException::ItemIdentityException: Cannot find a group named  in ResourceGroupManager::isResourceGroupInitialised at C:\Users\runneradmin\.conan2\p\b\ogre30c15d995aab6a\b\OgreMain\src\OgreResourceGroupManager.cpp (line 1772)
@CuriousMike56 CuriousMike56 changed the title Trucks with matching filenames don't spawn correctly Actors with matching filenames don't spawn correctly Jul 17, 2024
@ohlidalp
Copy link
Member

ohlidalp commented Aug 1, 2024

Thanks for reporting, this doesn't surprise me, some of the spawn logic is old code that uses resource groups wrong or not at all and I didn't change it to avoid backwards compatibility regressions.

I should be able to patch it without major remake.

ohlidalp added a commit to ohlidalp/rigs-of-rods that referenced this issue Aug 1, 2024
Fixes RigsOfRods#3166

Problem: When spawning an actor, the cache entry was always looked up via truckfile name, even if it was already known from the Selector UI. This potentially caused mixups.

Fix: Use the entry provided by Selector UI.
ohlidalp added a commit to ohlidalp/rigs-of-rods that referenced this issue Sep 1, 2024
Fixes RigsOfRods#3166

Problem: When spawning an actor, the cache entry was always looked up via truckfile name, even if it was already known from the Selector UI. This potentially caused mixups.

Fix: Use the entry provided by Selector UI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants