Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ It will (probably) break soon. #15

Open
RienNeVaPlus opened this issue Apr 9, 2022 · 8 comments
Open

⚠️ It will (probably) break soon. #15

RienNeVaPlus opened this issue Apr 9, 2022 · 8 comments
Assignees
Labels
help wanted Extra attention is needed

Comments

@RienNeVaPlus
Copy link
Owner

A few days ago, wikifolio announced a relaunch, which is highly likely to break this API - please be warned.

I will try to fix things, but there will be a delay, as this is a side project of my free time.
Pull requests are always welcome.

@RienNeVaPlus RienNeVaPlus added the help wanted Extra attention is needed label Apr 9, 2022
@RienNeVaPlus RienNeVaPlus self-assigned this Apr 9, 2022
@RienNeVaPlus RienNeVaPlus changed the title ⚠️ I will (propably) break soon. ⚠️ It will (propably) break soon. Apr 9, 2022
@RienNeVaPlus RienNeVaPlus changed the title ⚠️ It will (propably) break soon. ⚠️ It will (probably) break soon. Apr 10, 2022
@wemakefuture
Copy link

Yes it broke. Error message is

"login failed, Cookie not found"

@jekru
Copy link
Contributor

jekru commented Apr 16, 2022

Yes it broke. Error message is

"login failed, Cookie not found"

See #18. If @RienNeVaPlus updates the npm package, it should work again.

@RienNeVaPlus
Copy link
Owner Author

RienNeVaPlus commented Apr 16, 2022

v0.4.2 published. But there's more broken. I miss the old layout.

@wemakefuture
Copy link

@RienNeVaPlus yeah - the old layout was smooth. Getting the trades is currently not working, patched 0.4.2.

Trying to grab the trades ends with a:
[-] No trades found.

@jekru
Copy link
Contributor

jekru commented Apr 18, 2022

@RienNeVaPlus yeah - the old layout was smooth. Getting the trades is currently not working, patched 0.4.2.

Trying to grab the trades ends with a: [-] No trades found.

Could you provide more details? And are you sure that the wikifolio has any trades? Because fetching wikifolio trades is working for me.

const api = new Api({email: '', password: ''});
const wikifolio = api.wikifolio('');
const trades = await wikifolio.trades();

console.log(trades);

@farhan-gif
Copy link

farhan-gif commented Apr 19, 2022

Hello, thanks for providing the api!
After the website upgrade, is the buy/sell function working for you guys? I get the below error for buy/sell
Error: Wikifolio JSON not found. This is probably a bug, please report it.
at Wikifolio. (C:\wikifolio\node_modules\wikifolio\dist\models\Wikifolio.js:294:35)
at step (C:\wikifolio\node_modules\wikifolio\dist\models\Wikifolio.js:44:23)
at Object.next (C:\wikifolio\node_modules\wikifolio\dist\models\Wikifolio.js:25:53)
at fulfilled (C:\wikifolio\node_modules\wikifolio\dist\models\Wikifolio.js:16:58)
at processTicksAndRejections (node:internal/process/task_queues:96:5)

Any help would be much appreciated

@henrydatei
Copy link

Hello, thanks for providing the api! After the website upgrade, is the buy/sell function working for you guys? I get the below error for buy/sell Error: Wikifolio JSON not found. This is probably a bug, please report it. at Wikifolio. (C:\wikifolio\node_modules\wikifolio\dist\models\Wikifolio.js:294:35) at step (C:\wikifolio\node_modules\wikifolio\dist\models\Wikifolio.js:44:23) at Object.next (C:\wikifolio\node_modules\wikifolio\dist\models\Wikifolio.js:25:53) at fulfilled (C:\wikifolio\node_modules\wikifolio\dist\models\Wikifolio.js:16:58) at processTicksAndRejections (node:internal/process/task_queues:96:5)

Any help would be much appreciated

I get the same error on other functions, see #19

@jekru
Copy link
Contributor

jekru commented May 2, 2022

I am currently debugging (and fixing) Wikifolio.ts. I already created a (draft) PR #20. If anyone wants to join me, let me know :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants