Solve weekly technical debt #56
Conversation
…reverse parameter in docstring
anastasiia-bilova
force-pushed
the
weekly-tech-debt
branch
from
692046d
to
79988e9
Compare
Codecov Report
@@ Coverage Diff @@
## develop #56 +/- ##
===========================================
- Coverage 97.04% 96.97% -0.07%
===========================================
Files 55 55
Lines 1083 1091 +8
===========================================
+ Hits 1051 1058 +7
- Misses 32 33 +1
Continue to review full report at Codecov.
|
| @@ -38,4 +38,5 @@ class GetStateListForm(Schema): | |||
| validate.Range(min=1, error='Limit must be greater than 0.'), | |||
| ], | |||
| ) | |||
| node_url = NodeUrlField(required=False) | |||
| reverse = fields.Boolean(required=False) | |||
There was a problem hiding this comment.
What a sense of it. Give, please, example when it cant be a bool.
There was a problem hiding this comment.
@Alladin9393, when you create bool argument using click —
remme-core-cli/cli/state/cli.py
Line 74 in 6a65cec
bool type in the according to the argument — remme-core-cli/cli/state/cli.py
Line 77 in 6a65cec
| @@ -82,6 +82,7 @@ def get_states(address, limit, head, reverse, node_url): | |||
| 'address': address, | |||
| 'limit': limit, | |||
| 'head': head, | |||
| 'reverse': reverse, | |||
There was a problem hiding this comment.
You send argument, but not return him.
There was a problem hiding this comment.
@Alladin9393, done.
cli/transaction/help.py
Outdated
| TRANSACTIONS_IDENTIFIERS_ARGUMENT_HELP_MESSAGE = 'Identifiers to get a list of transactions by.' | ||
| TRANSACTIONS_START_ARGUMENT_HELP_MESSAGE = 'Transaction identifier to get a list transaction starting from.' | ||
| TRANSACTIONS_LIMIT_ARGUMENT_HELP_MESSAGE = 'Maximum amount of transactions to return.' | ||
| TRANSACTIONS_HEAD_ARGUMENT_HELP_MESSAGE = 'Block identifier to get a list of transactions from.' |
There was a problem hiding this comment.
@Alladin9393, done.
Solved
reverse.reverse = '' if reverse else 'false'— https://github.com/Remmeauth/remme-core-cli/blob/develop/cli/transaction/service.py#L41.RuntimeWarning: coroutine '' was never awaited) from tests output.cli/clis/from project (https://github.com/Remmeauth/remme-core-cli/tree/develop/cli/clis), https://github.com/Remmeauth/remme-core-cli/tree/develop/cli/services, https://github.com/Remmeauth/remme-core-cli/blob/develop/tests/__init.py.required=FalsefromNodeUrlFieldas it get valeu always.nodeto variables configurations and peers in the Node class.References