REM-1313: Implement getting only identifiers of batches #51

Art17 · 2019-05-14T13:32:28Z

Jira references

Ticket (task) — https://remmeio.atlassian.net/browse/REM-1414

Description

Get a list of batch identifiers — remme batch get-list --ids-only:

Arguments	Type	Required	Description
ids	String	No	Identifiers to get a list of batches by.
start	String	No	Batch identifier to get a list of batches starting from.
limit	Integer	No	Maximum amount of batches to return.
head	String	No	Block identifier to get a list of batches from.
reverse	Bool	No	Parameter to reverse result.
ids-only	Bool	No	Command flag to return batch identifiers only.
node-url	String	No	Node URL to apply a command to.

$ remme batch get-list
--limit=2
--ids-only
--node-url=node-6-testnet.remme.io
{
"result": [
"e4d5089f2ef15d20818b937e1fcf05e04b70ef6860069b31f441124e8d53243f35c265190520b25da07c3eb47354e6e145c6e52229683829dba6b0f185b3b6ca",
"df5e555f9e014e6d6d08b25f82698a1cf06eff4a11e941c0284f210d7b1535d3542f37dd5546d2fc08d51a866910317987933107c1cd2ef14860d0317f039501"
]
}

dmytrostriletskyi · 2019-05-14T15:31:56Z

README.md

@@ -502,7 +503,16 @@ $ remme batch get-list \
        }
    ]
 }
-
+$ remme batch get-list \


At this section where we describe only --ids-only. So we should remove excess parameters. I mean refactor to:

$ remme batch get-list --ids-only --node-url=node-6-testnet.remme.io { "result": [ "e4d5089f2ef1...6b0f185b3b6ca", "df5e555f.317f039501", ... ] }

dmytrostriletskyi · 2019-05-14T15:36:39Z

cli/batch/cli.py

-        reverse=reverse,
-    )
+    if ids_only:
+        result, errors = Batch(service=remme).get_ids(


get_ids > get_list_ids.

dmytrostriletskyi · 2019-05-14T15:37:00Z

cli/batch/interfaces.py

+
+    def get_ids(self, ids, start, limit, head, reverse):
+        """
+        Get a list of batches.


Get a list of batches > Get a list of batches' identifiers.

codecov-io · 2019-05-15T14:57:46Z

Codecov Report

Merging #51 into develop will decrease coverage by 0.14%.
The diff coverage is 88.88%.

@@             Coverage Diff             @@
##           develop      #51      +/-   ##
===========================================
- Coverage    97.22%   97.07%   -0.15%     
===========================================
  Files           55       55              
  Lines         1009     1026      +17     
===========================================
+ Hits           981      996      +15     
- Misses          28       30       +2

Impacted Files	Coverage Δ
cli/batch/help.py	`100% <100%> (ø)`	⬆️
cli/batch/forms.py	`100% <100%> (ø)`	⬆️
cli/batch/cli.py	`100% <100%> (ø)`	⬆️
cli/batch/interfaces.py	`55.55% <50%> (-1.59%)`	⬇️
cli/batch/service.py	`92.68% <88.88%> (-1.07%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f7c87a...1ac9565. Read the comment docs.

dmytrostriletskyi · 2019-05-16T14:19:13Z

README.md

@@ -577,7 +578,14 @@ $ remme batch get-list \
        }
    ]
 }
-
+$ remme batch get-list --ids-only --node-url=node-6-testnet.remme.io


Add the sentence which is in transactions example.

https://github.com/Remmeauth/remme-core-cli/blob/develop/README.md

dmytrostriletskyi · 2019-05-16T14:20:13Z

cli/batch/help.py

@@ -8,3 +8,4 @@
 BATCH_REVERSE_ARGUMENT_HELP_MESSAGE = 'Parameter to reverse result.'
 BATCH_STATUS_IDENTIFIER_ARGUMENT_HELP_MESSAGE = 'Identifier to get a batch status by.'
 BATCH_ID_ARGUMENT_HELP_MESSAGE = 'Identifier to get a batch by.'
+BATCH_IDENTIFIERS_ONLY_ARGUMENT_HELP_MESSAGE = 'Command flag to return batch identifiers only.'


The flag to get a list of batches' identifiers.

Change in README also.

dmytrostriletskyi · 2019-05-16T14:21:18Z

cli/batch/interfaces.py

+
+    def get_list_ids(self, ids, start, limit, head, reverse):
+        """
+        Get a list of batch identifiers.


batch > batches'.

dmytrostriletskyi · 2019-05-16T14:21:23Z

cli/batch/service.py

+
+    def get_list_ids(self, ids, start, limit, head, reverse):
+        """
+        Get a list of batch identifiers.


batch > batches'.

@Art17, do not see changes —

remme-core-cli/cli/batch/service.py

Line 99 in c48c11e

Get a list of batch identifiers.

.

dmytrostriletskyi · 2019-05-16T14:22:08Z

cli/constants.py

+LATEST_RELEASE_NODE_IP_ADDRESS_FOR_TESTING = '165.22.75.163'
+RELEASE_0_9_0_ALPHA_NODE_ADDRESS = '165.227.169.119'
+NODE_1_IN_TESTNET_ADDRESS = 'node-1-testnet.remme.io'
+NODE_27_IN_TESTNET_ADDRESS = 'node-27-testnet.remme.io'


Remove this. It is old code.

dmytrostriletskyi · 2019-05-16T16:02:51Z

README.md

@@ -982,4 +991,4 @@ If you are new for the contribution, please read:
 If you want to your pull request to be review, ensure you:
 1. [Branch isn't out-of-date with the base branch](https://habrastorage.org/webt/ux/gi/wm/uxgiwmnft08fubvjfd6d-8pw2wq.png).
 2. [Have written the description of the pull request and have added at least 2 reviewers](https://github.com/camo/55c309334a8b61a4848a6ef25f9b0fb3751ae5e9/68747470733a2f2f686162726173746f726167652e6f72672f776562742f74312f70792f63752f7431707963753162786a736c796f6a6c707935306d7862357969652e706e67).
-3. [Continuous integration has been passed](https://habrastorage.org/webt/oz/fl/-n/ozfl-nl-jynrh7ofz8yuz9_gapy.png).
+3. [Continuous integration has been passed](https://habrastorage.org/webt/oz/fl/-n/ozfl-nl-jynrh7ofz8yuz9_gapy.png).


Why it has been changed?

dmytrostriletskyi · 2019-05-16T16:03:44Z

cli/batch/service.py

+
+    def get_list_ids(self, ids, start, limit, head, reverse):
+        """
+        Get a list of batch identifiers.


@Art17, do not see changes —

remme-core-cli/cli/batch/service.py

Line 99 in c48c11e

Get a list of batch identifiers.

.

Art17 requested review from anastasiia-bilova and dmytrostriletskyi May 14, 2019 13:33

Art17 force-pushed the get-batches-ids-only branch 2 times, most recently from f8fdd87 to 663a56e Compare May 14, 2019 15:27

dmytrostriletskyi suggested changes May 14, 2019

View reviewed changes

Annitra self-requested a review May 16, 2019 07:44

Annitra approved these changes May 16, 2019

View reviewed changes

dmytrostriletskyi suggested changes May 16, 2019

View reviewed changes

Art17 force-pushed the get-batches-ids-only branch 2 times, most recently from e9c369f to c48c11e Compare May 16, 2019 15:39

dmytrostriletskyi suggested changes May 16, 2019

View reviewed changes

Art17 force-pushed the get-batches-ids-only branch 3 times, most recently from ec95672 to 7097db5 Compare May 16, 2019 16:28

REM-1313: Implement getting only identifiers of batches

1ac9565

Art17 force-pushed the get-batches-ids-only branch from 7097db5 to 1ac9565 Compare May 16, 2019 16:29

dmytrostriletskyi approved these changes May 16, 2019

View reviewed changes

Art17 merged commit 3c18461 into develop May 16, 2019

delete-merged-branch bot deleted the get-batches-ids-only branch May 16, 2019 16:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

REM-1313: Implement getting only identifiers of batches #51

REM-1313: Implement getting only identifiers of batches #51

Art17 commented May 14, 2019

dmytrostriletskyi May 14, 2019

Art17 May 14, 2019

dmytrostriletskyi May 14, 2019

Art17 May 14, 2019

dmytrostriletskyi May 14, 2019

Art17 May 14, 2019

codecov-io commented May 15, 2019 •

edited

Loading

dmytrostriletskyi May 16, 2019

Art17 May 16, 2019

dmytrostriletskyi May 16, 2019

Art17 May 16, 2019

dmytrostriletskyi May 16, 2019

Art17 May 16, 2019

dmytrostriletskyi May 16, 2019

Art17 May 16, 2019

dmytrostriletskyi May 16, 2019

dmytrostriletskyi May 16, 2019

Art17 May 16, 2019

dmytrostriletskyi May 16, 2019

Art17 May 16, 2019

dmytrostriletskyi May 16, 2019

REM-1313: Implement getting only identifiers of batches #51

REM-1313: Implement getting only identifiers of batches #51

Conversation

Art17 commented May 14, 2019

Jira references

Description

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov-io commented May 15, 2019 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov-io commented May 15, 2019 •

edited

Loading