Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement getting blocks identifiers #50

Merged
merged 16 commits into from
May 16, 2019
Merged

Conversation

dmytrostriletskyi
Copy link
Contributor

@dmytrostriletskyi dmytrostriletskyi commented May 13, 2019

Jira references

Description

Get a list of blocks' identifiers (can be combined with other parameters like --limit):

Example of the usage:

$ remme block get-list --ids-only --node-url=node-6-testnet.remme.io
{
   "result": [
       "b757c74fbcd57ae12577b71490878affb6b688434c2e20170138760e72e937ca1bb3d6773e2ef37b5151ed74dcb663114a181072e0870e7a4d452c58659a6dbb",
       "585f23725d1236e90e2b961b0c0c1404aba0ba5a96e4d85cd2f048b1d61b027669153e3618c84fc09a8041f8e149b97d50a89ee7761d0458cd57c63d5f354cbd",
       ...
   ]
}

@dmytrostriletskyi dmytrostriletskyi changed the base branch from get-blocks-command to develop May 16, 2019 14:10
@codecov-io
Copy link

codecov-io commented May 16, 2019

Codecov Report

Merging #50 into develop will decrease coverage by 0.05%.
The diff coverage is 93.75%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #50      +/-   ##
===========================================
- Coverage    97.07%   97.02%   -0.06%     
===========================================
  Files           55       55              
  Lines         1026     1041      +15     
===========================================
+ Hits           996     1010      +14     
- Misses          30       31       +1
Impacted Files Coverage Δ
cli/block/cli.py 100% <100%> (ø) ⬆️
cli/block/forms.py 100% <100%> (ø) ⬆️
cli/block/help.py 100% <100%> (ø) ⬆️
cli/block/service.py 96.96% <88.88%> (-3.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c18461...fbd0c21. Read the comment docs.

@dmytrostriletskyi dmytrostriletskyi requested review from Art17 and removed request for Alladin9393 May 16, 2019 15:19
"""
Get a list of blocks identifiers.

A list of blocks identifiers could be filtered by blocks identifiers, limit, head, reverse.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocks > blocks'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Art17, done.

@dmytrostriletskyi dmytrostriletskyi merged commit 83a1fd9 into develop May 16, 2019
@delete-merged-branch delete-merged-branch bot deleted the get-blocks-ids-only branch May 16, 2019 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants